Review 12.4 Merged

82668[BUGFIX] Indexed Search: Pass `freeIndexUid` to `pageBrowsing` ViewHelper

Andreas Kienast CR +2 V +2 Easy +4 −4 updated 01/29/24, 18:23

Commit message

The `is:pageBrowsing` ViewHelper now receives the `freeIndexUid`
argument. Also, a typing issue in the data attribute is solved to let
JavaScript get its value.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Andreas Kienast uploaded patch set 1 01/27/24, 12:35

  2. core-ci voted on patch set 1 V +1 01/27/24, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52293

  3. Simon Schaufelberger voted on patch set 1 CR +1 V +1 01/27/24, 12:51

  4. Christian Kuhn voted on patch set 1 CR +1 V +1 01/27/24, 18:21

  5. Stefan Bürk voted on patch set 1 CR +1 V +1 01/29/24, 15:31

  6. Andreas Kienast voted on patch set 1 CR +2 V +2 01/29/24, 18:07

  7. Andreas Kienast merged patch set 2 01/29/24, 18:23