Review main Merged

82673[TASK] Improve type annotations for (Lazy)ObjectStorage

Oliver Klee CR +2 V +2 Easy +23 −21 updated 01/28/24, 12:35

Commit message

Make proper use of generics and align the API of our classes
with that of the implemented interfaces `Iterator` and
`ArrayAccess`.

This helps extension developers use static analysis for their
extensions.

This is a pre-patch to introducing native types for the two
classes.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 68

  1. Oliver Klee uploaded patch set 1 01/27/24, 17:10

  2. core-ci voted on patch set 1 V +1 01/27/24, 17:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52306

  3. Simon Schaufelberger voted on patch set 1 CR +1 V +1 01/27/24, 18:36

  4. Oliver Klee rebased onto patch set 2 CR +1 V +1 01/28/24, 09:32

  5. core-ci voted on patch set 2 V +1 01/28/24, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52347

  6. Simon Schaufelberger voted on patch set 2 CR +1 V +1 01/28/24, 09:49

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 01/28/24, 12:35

  8. Christian Kuhn merged patch set 3 01/28/24, 12:35