Review main Merged Breaking

82686[!!!][TASK] Avoid FormEngine itemFormElID

Christian Kuhn CR +2 V +2 Normal +97 −43 updated 01/28/24, 13:09

Commit message

$this->data['parameterArray']['itemFormElID'] is kinda ugly
in FormEngine preparation, especially with flex form
elements.

Nowadays, the casual use case for 'per element'
id's is to connect HTML input elements to a label element.

This can be easily done in single element classes and
needs no framework support. Some core classes do this
aready.

The patch drops 'itemFormElID' and adapts remaining
consuming FormEngine element classes to create a unique
id per element usage on their own.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 79

  1. Christian Kuhn uploaded patch set 1 01/28/24, 10:58

  2. core-ci voted on patch set 1 V +1 01/28/24, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52352

  3. Christian Kuhn uploaded patch set 2 V +1 01/28/24, 11:43

  4. core-ci voted on patch set 2 V +1 01/28/24, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52357

  5. Oliver Klee voted on patch set 2 CR +1 01/28/24, 12:15

  6. Benni Mack voted on patch set 2 CR +1 V +1 01/28/24, 12:30

  7. Oliver Klee voted on patch set 2 V +1 01/28/24, 13:08

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 01/28/24, 13:09

  9. Christian Kuhn merged patch set 3 01/28/24, 13:09