Review main Merged Breaking

82689[!!!][TASK] Prevent DB relations in flex container sections

Christian Kuhn CR +2 V +2 Normal +93 −139 updated 01/29/24, 10:17

Commit message

Flex form container sections have been restricted to
not contain type=inline, type=group with MM and some
furter combinatios with previous core versions before.

The patch extends this to a general "Do not configure
flex form container sections that have database relations".
It modifies the according code in FormEngine
TcaFlexProcess->scanForInvalidSectionContainerTca()
accordingly. This check can be re-located to a more low
level tailored flex form handling related class, later.

The attached documentation ReST file comes with some
reasons on why such a configuration is very problematic
to be handled by the core in a good way.

This patch unblocks further flex form development
to actually fix existing issues with database
relations within flex forms that are bound to casual
fields not within container sections.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 912

  1. Christian Kuhn uploaded patch set 1 01/28/24, 13:10

  2. core-ci voted on patch set 1 V +1 01/28/24, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52364

  3. Christian Kuhn uploaded patch set 2 V +1 01/28/24, 14:22

  4. Christian Kuhn updated the commit message in patch set 3 01/28/24, 14:24

  5. core-ci voted on patch set 3 V +1 01/28/24, 14:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52370

  6. core-ci voted on patch set 2 V +1 01/28/24, 14:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52369

  7. Nikita Hovratov voted on patch set 3 CR +1 01/28/24, 16:19

  8. Oliver Klee voted on patch set 3 V +1 01/28/24, 16:31

  9. Nikita Hovratov voted on patch set 3 V +1 01/28/24, 16:31

  10. Benni Mack voted on patch set 3 CR +1 V +1 01/29/24, 10:17

  11. Christian Kuhn voted on patch set 3 CR +2 V +2 01/29/24, 10:17

  12. Christian Kuhn merged patch set 4 01/29/24, 10:17