82723[TASK] Add visually-hidden label to CheckboxToggleElement
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Michael Telgkamp +1
-
Verified V +2 Done
- Christian Kuhn +2
- Michael Telgkamp +1
- core-ci +1 CI
Issues 1
Files 1
Review log 3143
Show 1318 earlier messages
-
Christian Rath-Ulrich uploaded patch set 1 01/30/24, 20:47
-
core-ci voted on patch set 1 V -1 01/30/24, 20:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52520
-
Guido Schmechel commented on patch set 1 01/30/24, 22:20
Commit message: label vs. lable :-) -
Guido Schmechel commented on patch set 1 01/30/24, 22:21
CheckboxToggleElement.php:161'label' -
Georg Ringer commented on patch set 1 01/30/24, 22:25
labelCheckboxToggleElement.php:183also please use hsc() to avoid xss -
Anja Leichsenring updated the commit message in patch set 2
V -101/31/24, 06:26 -
core-ci voted on patch set 2 V -1 01/31/24, 06:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52528
-
Christian Rath-Ulrich updated the commit message in patch set 3
V -101/31/24, 08:58 -
core-ci voted on patch set 3 V -1 01/31/24, 09:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52544
-
Christian Rath-Ulrich uploaded patch set 4
V -101/31/24, 10:24 -
Christian Rath-Ulrich commented on patch set 4 01/31/24, 10:25
Reply
DoneCheckboxToggleElement.php:161ReplyDoneCheckboxToggleElement.php:183ReplyDone -
core-ci voted on patch set 4 V -1 01/31/24, 10:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52551
-
Christian Kuhn commented on patch set 4 01/31/24, 11:12
how does this patch relate to this one: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82150 ? -
Christian Rath-Ulrich commented on patch set 4 01/31/24, 11:50
Reply
There is a small conflict but my changes solving another issue he is mainly reworking the old labels to a legend I am adding a sufficient label to the single toggle -
Christian Rath-Ulrich uploaded patch set 5
V -101/31/24, 15:53 -
core-ci voted on patch set 5 V +1 01/31/24, 15:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52560
-
Albrecht Köhnlein commented on patch set 5 CR -1 01/31/24, 18:48
CheckboxToggleElement.php:160I'm afraid this could cause PHP warnings in case the [label] does not exist. What about checking with `isset()` or use `$additionalInformation['fieldConf']['label'] ?? ''` to not run into warnings?CheckboxToggleElement.php:182I really welcome accessibility improvements, but is there a reason to provide the label in debug mode only? Why not render it for non-debug mode too?CheckboxToggleElement.php:186No need for this additional line -
Albrecht Köhnlein commented on patch set 5 01/31/24, 18:49
Please clean up the mix of single `'` and double quotes `"`
-
Christian Rath-Ulrich updated the commit message in patch set 6
CR -1V +102/05/24, 12:17 -
core-ci voted on patch set 6 V +1 02/05/24, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52722
-
Christian Rath-Ulrich commented on patch set 6 02/05/24, 12:28
Reply
Done -
Albrecht Köhnlein commented on patch set 6 02/05/24, 14:15
CheckboxToggleElement.php:182ReplySorry, my mistake. It's fine. -
Christian Rath-Ulrich uploaded patch set 7
V +102/07/24, 10:23 -
Christian Rath-Ulrich commented on patch set 7 02/07/24, 10:28
CheckboxToggleElement.php:160ReplyDoneCheckboxToggleElement.php:186ReplyDone -
core-ci voted on patch set 7 V +1 02/07/24, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52843
-
Jasmina Ließmann commented on patch set 7 06/24/24, 11:01
I'm not sure whether simply adding the label text adds any value, because currently it results in the following code: ``` <div class="form-check form-switch"> <input type="checkbox" ... /> <label class="form-check-label" for="###"> [1]<span class="visually-hidden"> Page visible</span> </label> </div> ``` Wouldn't it make sense to use descriptive texts like "enabled/disabled" or "activated/deactivated"? Possibly for all users? -
Jasmina Ließmann commented on patch set 7 06/24/24, 11:05
Reply
As a supplement: Only admin users see the [0] and [1]. Without the patch there isn't any label text at all, with this patch editors see "Page visible" for both states. -
Christian Rath-Ulrich uploaded patch set 8
V +107/16/24, 13:34 -
core-ci voted on patch set 8 V +1 07/16/24, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61638
-
Christian Rath-Ulrich uploaded patch set 9
V +107/18/24, 17:14 -
core-ci voted on patch set 9 V +1 07/18/24, 17:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61753
-
Jasmina Ließmann commented on patch set 9 07/18/24, 17:57
Reply
Resolved with latest patchset. -
Jasmina Ließmann updated the commit message in patch set 10
V +107/18/24, 18:58 -
core-ci voted on patch set 10 V -1 07/18/24, 19:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61758
-
core-ci voted on patch set 10 V +1 07/18/24, 19:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61758
-
Michael Telgkamp commented on patch set 10 CR -1 07/23/24, 07:38
CheckboxToggleElement.php:180To improve the accessibility the input should get the attribute `role="switch"`.CheckboxToggleElement.php:182Having the `role="switch"` would already announce the role of the element to assistive technologies. Thus, the label should not have the `Toggle` included, as it is available through the role. A static content for all elements should also be added at the end, so users of assistive technologies can skip it and have the important information available first. -
Christian Rath-Ulrich uploaded patch set 11
CR -1V +108/05/24, 15:18 -
Christian Rath-Ulrich commented on patch set 11 08/05/24, 15:26
CheckboxToggleElement.php:180Replyadded the roleCheckboxToggleElement.php:182Replyremoved the lable -
core-ci voted on patch set 11 V +1 08/05/24, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62854
-
Michael Telgkamp voted on patch set 11 CR +1 V +1 08/06/24, 10:18
-
Christian Kuhn voted on patch set 11 CR +1 V +1 08/06/24, 10:29
-
Christian Kuhn voted on patch set 11 CR +2 V +2 08/06/24, 10:38
-
Christian Kuhn merged patch set 12 08/06/24, 10:38