82736[TASK] Revert "[TASK] Add title and aria-label to clear input button"
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Benjamin Kott +1
- Willi Wehmeier +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Benjamin Kott +1
- core-ci +1 CI
Issues 2
Files 5
- Build/Sources/TypeScript/backend/input/clearable.ts+0 −5
- typo3/sysext/backend/Classes/Controller/LoginController.php+0 −14
- typo3/sysext/backend/Classes/Controller/ResetPasswordController.php+0 −12
- typo3/sysext/backend/Resources/Public/JavaScript/input/clearable.js+1 −1
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+0 −3
Review log 1114
-
Benjamin Franzke uploaded patch set 1 01/31/24, 07:56
-
Anja Leichsenring voted on patch set 1 CR +1 V +1 01/31/24, 08:00
-
core-ci voted on patch set 1 V +1 01/31/24, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52539
-
Benjamin Franzke updated the commit message in patch set 2
CR +1V +101/31/24, 08:03 -
Anja Leichsenring commented on patch set 1 CR +1 V +1 01/31/24, 08:04
aria-label might be superflous, but the title attribute should be added. -
Benjamin Franzke commented on patch set 2 CR -1 01/31/24, 08:06
We'll discuss this with Willi before merging the revert. -
core-ci voted on patch set 2 V +1 01/31/24, 08:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52541
-
Benjamin Franzke updated the commit message in patch set 3
CR -1V +101/31/24, 08:23 -
core-ci voted on patch set 3 V +1 01/31/24, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52542
-
Willi Wehmeier voted on patch set 3 CR -1 01/31/24, 08:31
-
Willi Wehmeier voted on patch set 3 CR +1 01/31/24, 08:31
-
Benjamin Kott voted on patch set 3 CR +1 V +1 01/31/24, 08:49
-
Benjamin Franzke voted on patch set 3 CR +2 V +2 01/31/24, 08:50
-
Benjamin Franzke merged patch set 4 01/31/24, 08:50