Review main Merged

82736[TASK] Revert "[TASK] Add title and aria-label to clear input button"

Benjamin Franzke CR +2 V +2 Easy +1 −35 updated 01/31/24, 08:50

Commit message

This reverts commit dba95382f4b2306080ace62a75a68a1e7b44fb63.

Reason for revert:

* The close button has tabIndex -1 so no aria-label is needed.
  Note: aria-label would have been useful in combination with #102372,
  but that patch was reverted as well, because with think a clearing
  button is not needed for keyboard users that use keyboard shortcuts
  anyway.
* The patch introduced new inline JavaScript which we want to avoid,
  also writing into TYPO3.lang directly via inline JavaScript is not
  ideal.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
    • Willi Wehmeier +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 1114

  1. Benjamin Franzke uploaded patch set 1 01/31/24, 07:56

  2. Anja Leichsenring voted on patch set 1 CR +1 V +1 01/31/24, 08:00

  3. core-ci voted on patch set 1 V +1 01/31/24, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52539

  4. Benjamin Franzke updated the commit message in patch set 2 CR +1 V +1 01/31/24, 08:03

  5. Anja Leichsenring commented on patch set 1 CR +1 V +1 01/31/24, 08:04

    aria-label might be superflous, but the title attribute should be added.
  6. Benjamin Franzke commented on patch set 2 CR -1 01/31/24, 08:06

    We'll discuss this with Willi before merging the revert.
  7. core-ci voted on patch set 2 V +1 01/31/24, 08:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52541

  8. Benjamin Franzke updated the commit message in patch set 3 CR -1 V +1 01/31/24, 08:23

  9. core-ci voted on patch set 3 V +1 01/31/24, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52542

  10. Willi Wehmeier voted on patch set 3 CR -1 01/31/24, 08:31

  11. Willi Wehmeier voted on patch set 3 CR +1 01/31/24, 08:31

  12. Benjamin Kott voted on patch set 3 CR +1 V +1 01/31/24, 08:49

  13. Benjamin Franzke voted on patch set 3 CR +2 V +2 01/31/24, 08:50

  14. Benjamin Franzke merged patch set 4 01/31/24, 08:50