Review main Merged

82776[TASK] Use stable `doctrine/dbal:^4`

Stefan Bürk CR +2 V +2 Easy +19 −28 updated 02/07/24, 11:32

Commit message

Doctrine DBAL released the stable version for
the next major version, v4.0.0. [1]

This change upgrades to the stable version
and ends the usage of the release candidate
as intermediate solution.

Stability workaround for the distribution
test composer.json is removed.

> \
  composer req --no-update --no-install \
    -d typo3/sysext/redirects \
    "doctrine/dbal":"^4.0" ; \
  composer req --no-update --no-install \
    -d typo3/sysext/core \
    "doctrine/dbal":"^4.0" ; \
  composer req --no-update --no-install \
    -d typo3/sysext/install \
    "doctrine/dbal":"^4.0" ; \
  composer req -W \
    "doctrine/dbal":"^4.0"

> COMPOSER=composer.dist.json composer rem --no-update \
    -d Build/composer "doctrine/dbal"

[1] https://github.com/doctrine/dbal/releases/tag/4.0.0

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Wand +1
    • Oliver Klee +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 7

Review log 79

  1. Stefan Bürk uploaded patch set 1 02/03/24, 21:05

  2. core-ci voted on patch set 1 V +1 02/03/24, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52664

  3. Oliver Klee commented on patch set 1 CR +1 V +1 02/03/24, 21:14

    Thanks!
  4. core-ci commented on patch set 1 02/03/24, 21:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52665

  5. Oliver Wand commented on patch set 1 CR +1 02/03/24, 21:34

    Great, thanks <3
  6. Anja Leichsenring voted on patch set 1 CR +1 V +1 02/03/24, 21:43

  7. Stefan Bürk voted on patch set 1 CR +2 V +2 02/03/24, 21:52

  8. Stefan Bürk merged patch set 2 02/03/24, 21:52

  9. Stefan Bürk commented on patch set 2 02/07/24, 11:32

    Added late backport for 13.0(.1)