82782[TASK] Drop unneeded TYPO3 version from package.json
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Oliver Klee +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1417
-
Andreas Kienast uploaded patch set 1 02/04/24, 15:24
-
core-ci voted on patch set 1 V +1 02/04/24, 15:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52687
-
Benjamin Franzke commented on patch set 1 02/04/24, 16:49
I guess we should justdrop the version (otherwise we should hook-it up to be auto-updated by darth). IIRC we can drop the version number and set `private` to `true` (which is useful anyway, as we'll not publish a node package from this package.json anyway. WDYT? -
Oliver Klee voted on patch set 1 CR +1 V +1 02/04/24, 20:11
-
Simon Schaufelberger voted on patch set 1 CR +1 V +1 02/04/24, 23:17
-
Andreas Kienast commented on patch set 1 CR -2 02/05/24, 06:36
Reply
Sounds reasonable to me. -
Benjamin Franzke uploaded patch set 2
CR +1V +102/05/24, 11:52Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Benjamin Franzke commented on patch set 2 02/05/24, 11:52
Reply
Done -
core-ci voted on patch set 2 V +1 02/05/24, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52717
-
Oliver Klee voted on patch set 2 CR +1 02/05/24, 12:03
-
Andreas Kienast voted on patch set 2 CR 0 02/05/24, 12:18
-
Benjamin Franzke uploaded patch set 3
CR +1V +102/05/24, 12:42 -
Benjamin Franzke commented on patch set 3 02/05/24, 12:43
Sorry, I forgot to remove the version from package-lock.json in patchset 2. Repushed. -
Oliver Klee voted on patch set 3 CR +1 V +1 02/05/24, 12:44
-
core-ci voted on patch set 3 V +1 02/05/24, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52725
-
Andreas Kienast voted on patch set 3 CR +2 V +2 02/05/24, 12:54
-
Andreas Kienast merged patch set 4 02/05/24, 12:54