Review main Merged

82817[BUGFIX] Handle record export and download options individually

Oli Bartsch CR +2 V +2 Normal +68 −13 updated 02/09/24, 17:34

Commit message

The "Export" button in the list module, used to
trigger exporting a table does now also respect
the `options.impexp.enableExportForNonAdminUser`
TSconfig option, preventing a permission exception.

The `mod.web_list.noExportRecordsLinks` is no
longer used for managing the display of the
"Download" button (displayed in the table's
header row), but instead a dedicated TSconfig
option `mod.web_list.displayRecordDownload`
is introduced. Using per-table syntax, it's
also possible to manage the "Download" Button
for each table individually.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1013

  1. Oli Bartsch uploaded patch set 1 02/06/24, 11:09

  2. core-ci voted on patch set 1 V -1 02/06/24, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52770

  3. Oli Bartsch uploaded patch set 2 V -1 02/06/24, 13:02

  4. core-ci voted on patch set 2 V +1 02/06/24, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52779

  5. Oli Bartsch uploaded patch set 3 V +1 02/09/24, 08:59

  6. core-ci voted on patch set 3 V +1 02/09/24, 09:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52941

  7. Jochen Roth voted on patch set 3 CR +1 V +1 02/09/24, 11:22

  8. Christian Kuhn commented on patch set 3 02/09/24, 12:18

    imho not important enough for v12. just get it done for v13 and that's it, then rename to feature. codewise fine. will upvote.
  9. Oli Bartsch commented on patch set 3 02/09/24, 13:08

    Reply

    We could argue whether this should go to v12, but it's IMO no feature as the TSconfig option was misused by the download component.
  10. Christian Kuhn voted on patch set 3 CR +1 V +1 02/09/24, 13:13

  11. Christian Kuhn commented on patch set 3 02/09/24, 13:14

    Reply

    ack
  12. Oli Bartsch voted on patch set 3 CR +2 V +2 02/09/24, 17:34

  13. Oli Bartsch merged patch set 4 02/09/24, 17:34