Review 12.4 Merged

82836[BUGFIX] Avoid autocompletion in TCA type password

Benjamin Franzke CR +2 V +2 Easy +3 −3 updated 02/13/24, 07:41

Commit message

The autocomplete="off" parameter is ignored by current browsers,
autocomplete="new-password" is to be used for disable autocompletion.

The explicit request for autocompleting the password is
autocomplete="current-password", which is now used in case config TCA
autocomplete is set.

See following article for more information:
 * https://web.dev/articles/sign-in-form-best-practices#new-password
 * https://web.dev/articles/sign-in-form-best-practices#current-password

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 57

  1. Benjamin Franzke commented on patch set 1 02/07/24, 09:20

    Cherry Picked from branch main.
  2. Benjamin Franzke marked it work in progress 02/07/24, 09:20

  3. core-ci voted on patch set 1 V +1 02/07/24, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52835

  4. Benjamin Franzke updated the commit message in patch set 2 V +1 02/07/24, 12:21

  5. core-ci voted on patch set 2 V +1 02/07/24, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52857

  6. Benjamin Franzke commented on patch set 2 CR +2 V +2 02/13/24, 07:41

    This change is ready for review.
  7. Benjamin Franzke merged patch set 3 02/13/24, 07:41