Review 12.4 Merged

82850[BUGFIX] Fix list view functionality in FileList

Oli Bartsch CR +2 V +2 Easy +8 −1 updated 02/12/24, 15:32

Commit message

This fixes several bugs in FileList:

1. Properly initializing the `searchTerm` ensures
   it is kept while sorting.
2. Sorting for "filesize" is now working properly,
   using corresponding collator attribute.
3. Pagination is properly reset on searching.
4. Correct search term is kept on paginating.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Oli Bartsch commented on patch set 1 02/12/24, 15:11

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/12/24, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53087

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 02/12/24, 15:32

  4. Oli Bartsch merged patch set 2 02/12/24, 15:32