Review main Abandoned

82861[FEATURE] Provide search input for file link handler

Daniel Siepmann CR 0 V 0 Normal +56 −1 updated 03/07/24, 12:08

Commit message

Add the existing search functionality from file list module to file link
handler.

Editors can now search for given file names within the selected folder
when creating a link to a file.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 45

  1. Daniel Siepmann uploaded patch set 1 02/08/24, 09:32

  2. core-ci voted on patch set 1 V +1 02/08/24, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52881

  3. Sybille Peters commented on patch set 1 02/09/24, 15:34

    FileLinkHandler.php:92

    I don't know if this is intentional, but the behaviour differs from the file list: In the file list, it also searches in subfolders, in link browser it does not. In link browser, it seams to work more like a filter - filtering files in currently selected dir.
  4. Mathias Brodala commented on patch set 1 03/07/24, 12:00

    FileLinkHandler.php:92 Reply Unresolved

    You could append ->withRecursive() just like in the FileListController if desired. Would make sense IMO to have a consistent behavior.
  5. Daniel Siepmann abandoned the change 03/07/24, 12:08