Review 12.4 Merged

82867[BUGFIX] Properly resolve GET parameter `id`

Stefan Bürk CR +2 V +2 Normal +114 −3 updated 02/09/24, 06:44

Commit message

This change ensures that `?id=` only
validates against an integer-interpreted
value, disallowing `?id=nonsense23` which
previously resolved to "23"

In case an invalid `?id=` parameter value
is provided throw a page not found error.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Stefan Bürk uploaded patch set 1 02/09/24, 06:37

  2. core-ci voted on patch set 1 V +1 02/09/24, 06:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52935

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 02/09/24, 06:44

  4. Stefan Bürk merged patch set 2 02/09/24, 06:44