Review main Merged

82898[BUGFIX] Ensure correct custom (sub)category handling in ConstantEditor

Stefan Bürk CR +2 V +2 Hard +164 −162 updated 02/13/24, 11:41

Commit message

The constant editor has been revamped with #98357 using the
new TypoScript parser introduced with TYPO3 v12 under the
hood.

For category and subCategory handling lower-cased keys have
been used, missing to lower-case the custom categories and
subcategories names (keys) integrator are able to add since
aeons. That leads to a failing match later on, and adding
constants to the generic `other` subcategory.

The revamped code supports only one category per subCategory
sorting value. The documentation say that this **should** be
omitted, but it worked in the past and broke with the revamped
implementation.

This change fixes muliple issues with the constant editor:

* Ensure that custom categories and subcategories are read
  lower-case, otherwise later lookup will fail and sorted
  into sub-categorie `other`.
* Add addtional array level to have `subCategory->items`
  per second sorting value as array (to avoid overriding).
* Add additional item loop to the fluid template to respect
  the additional array level.

Note: In the past it was possible to display a constant
in multiple categories/subcategories by adding them again
with different category configure comment lines. This is
not supported anymore and not considered as bug.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • Thomas Anders +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 912

  1. Stefan Bürk uploaded patch set 1 02/12/24, 12:36

  2. core-ci voted on patch set 1 V +1 02/12/24, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53083

  3. Stefan Bürk updated the commit message in patch set 2 V +1 02/12/24, 12:48

  4. core-ci voted on patch set 2 V +1 02/12/24, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53084

  5. Stefan Bürk updated the commit message in patch set 3 V +1 02/12/24, 15:31

  6. core-ci voted on patch set 3 V +1 02/12/24, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53094

  7. Oli Bartsch voted on patch set 3 CR +1 V +1 02/12/24, 16:11

  8. Thomas Anders voted on patch set 3 V +1 02/13/24, 10:56

  9. Thomas Anders commented on patch set 3 02/13/24, 11:00

    Successfully reviewed with my previously broken testcases
  10. Christian Kuhn voted on patch set 3 CR +1 V +1 02/13/24, 11:22

  11. Stefan Bürk voted on patch set 3 CR +2 V +2 02/13/24, 11:34

  12. Stefan Bürk merged patch set 4 02/13/24, 11:41