Review main Merged

82934[TASK] Use correct command dispatch in `runTests.sh`

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 02/22/24, 10:30

Commit message

The command dispatch for `-s phpstanGenerateBaseline`
is modified to a simple command dispatch instead of
the bash expansion - which is not needed in this case.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Stefan Bürk uploaded patch set 1 02/13/24, 05:56

  2. core-ci voted on patch set 1 V +1 02/13/24, 06:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53113

  3. Benjamin Franzke commented on patch set 1 02/13/24, 07:45

    runTests.sh:965

    Hm, I do not see any benefit, besides an additional `fork()` syscall (which is a downside)? (We should probably just use `COMMAND=()` in line 964 – don't know why I missed to update that line back then, probably because it doesn't use `$@`)
  4. Stefan Bürk commented on patch set 1 02/15/24, 15:48

    runTests.sh:965 Reply

    Basically the same as other - except they have multiple command which does not work with a single `COMMAND=(...)` - for example L950/L951. As the `$@` is not needed here I decided to use that variant. Bascially, for this one command it does not matter. ``` COMMAND="cd Build; npm ci || exit 1; node_modules/grunt/bin/grunt exec:lintspaces" ``` would not work as ``` COMMAND=(cd Build; npm ci || exit 1; node_modules/grunt/bin/grunt exec:lintspaces) ``` So either here the single command `COMMAND=()` or the way back. What do you think ? However, currently this command does not work in the current state. So we need a fix, I would say.
  5. Christian Kuhn uploaded patch set 2 V +1 02/22/24, 09:25

  6. Christian Kuhn commented on patch set 1 02/22/24, 09:26

    runTests.sh:965 Reply

    I'd say this does not matter much, and I find the proposed solution by Stefan a bit more easy to parse in my head. imho, just keep it, or do you have hard feelings here, Benjamin? I'm interested in getting something merged, since the command is currently broken.
  7. Christian Kuhn voted on patch set 2 CR +1 V +1 02/22/24, 09:28

  8. core-ci voted on patch set 2 V +1 02/22/24, 09:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53435

  9. Benjamin Franzke commented on patch set 2 CR +1 V +1 02/22/24, 09:52

    runTests.sh:965 Reply

    Fine with me.
  10. Stefan Bürk voted on patch set 2 CR +2 V +2 02/22/24, 10:12

  11. Stefan Bürk merged patch set 3 02/22/24, 10:30