Review 12.4 Merged

82950[SECURITY] Deny directly modifying file abstraction layer entities

Oliver Hader CR +2 V +2 Hard +361 −0 updated 02/13/24, 09:33

Commit message

Write access to table `sys_file` is denied per default, unless data
is being imported. In addition, write access to related FAL entities
`sys_file_reference` and `sys_file_metadata` is denied in case a file
on legacy storage (uid=0) is used or corresponding user does not have
permissions to access a particular file.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 1

Files 20

Review log 34

  1. Oliver Hader uploaded patch set 1 02/13/24, 09:06

  2. Oliver Hader commented on patch set 1 CR +2 V +2 02/13/24, 09:06

    Auto-approved
  3. Oliver Hader merged patch set 2 02/13/24, 09:06

  4. core-ci voted on patch set 1 V +1 02/13/24, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53142