Review main Merged

82993[BUGFIX] Fix mixed up `$cachingEnabled` property in BootCompletedEvent

Nikita Hovratov CR +2 V +2 Easy +1 −1 updated 02/14/24, 12:05

Commit message

The BootCompletedEvent receives the constructor argument
`$cachingEnabled`. However, the variable `$disableCaching` was passed
in Bootstrap::init() which is the exact opposite. In fact, the caching
is logically always enabled when reaching the dispatched event.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Nikita Hovratov uploaded patch set 1 02/14/24, 00:26

  2. core-ci voted on patch set 1 V +1 02/14/24, 00:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53182

  3. Benni Mack commented on patch set 1 02/14/24, 06:52

    Why is caching always enabled? as far as I understand, the Bootstrap::init() is also used for the Install Tool, where the Failsafe Container is used and caching is not enabled. $disableCaching = $failsafe ? true : false;
  4. Stefan Bürk commented on patch set 1 02/14/24, 07:05

    Reply

    Literally, @nikita.h@live.de is right. if `$failsafe` is `true`, there is a early return and therefore not dispatching the event: ```php if ($failsafe) { $bootState->complete = true; return $container; } ``` https://review.typo3.org/c/Packages/TYPO3.CMS/+/82993/1/typo3/sysext/core/Classes/Core/Bootstrap.php#147
  5. Stefan Bürk voted on patch set 1 CR +1 V +1 02/14/24, 08:41

  6. Benni Mack commented on patch set 1 CR +1 V +1 02/14/24, 11:44

    thanks for enlighting me!
  7. Nikita Hovratov voted on patch set 1 CR +2 V +2 02/14/24, 12:05

  8. Nikita Hovratov merged patch set 2 02/14/24, 12:05