Review main Merged

82995[BUGFIX] Fix ContextMenu positioning race conditions

Benjamin Franzke CR +2 V +2 Normal +51 −35 updated 03/04/24, 09:16

Commit message

Read mouse position from the triggering event instead of relying
on values from a throttled mousemove event, which caused race
conditions where mouse position was not updated at all when moving
the mouse from iframe to outer frame.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1014

  1. Benjamin Franzke uploaded patch set 1 02/14/24, 07:42

  2. core-ci voted on patch set 1 V +1 02/14/24, 07:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53189

  3. Benjamin Kott uploaded patch set 2 V +1 02/28/24, 08:27

  4. core-ci voted on patch set 2 V +1 02/28/24, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53673

  5. Benjamin Franzke uploaded patch set 3 V +1 02/29/24, 09:47

  6. core-ci voted on patch set 3 V +1 02/29/24, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53709

  7. Andreas Kienast commented on patch set 3 02/29/24, 11:47

    context-menu.ts:148

    Can't we use `this.mousePos` here?
  8. Benjamin Franzke uploaded patch set 4 V +1 02/29/24, 11:56

  9. Benjamin Franzke commented on patch set 4 02/29/24, 11:56

    context-menu.ts:148 Reply

    Acknowledged (I initially wanted to get rid of this.mousePos at some point entirely, but needed to let it live for submenus – so yea, I've reused that structure here)
  10. core-ci voted on patch set 4 V +1 02/29/24, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53716

  11. Andreas Kienast commented on patch set 4 CR +1 V +1 02/29/24, 12:16

    context-menu.ts:148 Reply

    I assumed that and I'm all in for getting rid of this property somewhen™
  12. Andreas Nedbal voted on patch set 4 CR +1 V +1 03/04/24, 08:22

  13. Andreas Kienast voted on patch set 4 CR +2 V +2 03/04/24, 09:07

  14. Andreas Kienast merged patch set 5 03/04/24, 09:16