82995[BUGFIX] Fix ContextMenu positioning race conditions
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Andreas Nedbal +1
-
Verified V +2 Done
- Andreas Kienast +2
- Andreas Nedbal +1
- core-ci +1 CI
Issues 1
Files 10
- Build/Sources/TypeScript/backend/tree/file-storage-tree-container.ts+2 −1
- Build/Sources/TypeScript/backend/tree/page-tree-element.ts+2 −1
- Build/Sources/TypeScript/backend/tree/tree.ts+2 −2
- Build/Sources/TypeScript/backend/context-menu.ts3+38 −24
- Build/Sources/TypeScript/filelist/file-list.ts+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/tree/file-storage-tree-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/tree/page-tree-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/tree/tree.js+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/context-menu.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/file-list.js+1 −1
Review log 1014
-
Benjamin Franzke uploaded patch set 1 02/14/24, 07:42
-
core-ci voted on patch set 1 V +1 02/14/24, 07:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53189
-
Benjamin Kott uploaded patch set 2
V +102/28/24, 08:27 -
core-ci voted on patch set 2 V +1 02/28/24, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53673
-
Benjamin Franzke uploaded patch set 3
V +102/29/24, 09:47 -
core-ci voted on patch set 3 V +1 02/29/24, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53709
-
Andreas Kienast commented on patch set 3 02/29/24, 11:47
-
Benjamin Franzke uploaded patch set 4
V +102/29/24, 11:56 -
Benjamin Franzke commented on patch set 4 02/29/24, 11:56
context-menu.ts:148ReplyAcknowledged (I initially wanted to get rid of this.mousePos at some point entirely, but needed to let it live for submenus – so yea, I've reused that structure here) -
core-ci voted on patch set 4 V +1 02/29/24, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53716
-
Andreas Kienast commented on patch set 4 CR +1 V +1 02/29/24, 12:16
context-menu.ts:148ReplyI assumed that and I'm all in for getting rid of this property somewhen™ -
Andreas Nedbal voted on patch set 4 CR +1 V +1 03/04/24, 08:22
-
Andreas Kienast voted on patch set 4 CR +2 V +2 03/04/24, 09:07
-
Andreas Kienast merged patch set 5 03/04/24, 09:16
context-menu.ts:148