82999[BUGFIX] Handle falsy return type when getting selected folder
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Oli Bartsch +1
- Oliver Hader +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Oli Bartsch +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1216
-
Andreas Kienast uploaded patch set 1 02/14/24, 15:18
-
Andreas Kienast updated the commit message in patch set 2 02/14/24, 15:18
-
Andreas Kienast uploaded patch set 3 02/14/24, 15:30
-
core-ci voted on patch set 1 V -1 02/14/24, 15:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53198
-
core-ci voted on patch set 2 V -1 02/14/24, 15:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53199
-
core-ci voted on patch set 3 V +1 02/14/24, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53200
-
Oli Bartsch voted on patch set 3 CR +1 V +1 02/14/24, 16:01
-
Markus Klein voted on patch set 3 CR +1 V +1 02/14/24, 16:15
-
Benjamin Franzke commented on patch set 3 02/14/24, 21:01
-
Benjamin Franzke uploaded patch set 4
CR +1V +102/14/24, 21:51 -
core-ci voted on patch set 4 V +1 02/14/24, 21:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53208
-
Benjamin Franzke commented on patch set 4 02/14/24, 22:25
FileLinkHandler.php:126ReplyFound a way to reproduce: getSelectedFolder() return false if backend user has no "default" upload folder, which is the case when all storages are marked non-writable. With that the error is actually reproducible in v11 when trying to create a new file link. … and therefore updated the patch (`=== false ||` was technically fine, but as I said I want to avoid any other regression because of xclasses or so). -
Oli Bartsch voted on patch set 4 CR +1 V +1 02/15/24, 08:54
-
Oliver Hader voted on patch set 4 CR +1 02/15/24, 09:10
-
Andreas Kienast voted on patch set 4 CR +2 V +2 02/15/24, 09:32
-
Andreas Kienast merged patch set 5 02/15/24, 09:32
FileLinkHandler.php:126