83027[TASK] Add composer-mode to our acceptance test matrix
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 29
- Build/composer/composer.dist.json+4 −2
- Build/gitlab-ci/nightly/acceptance-application-composer.yml1new+163 −0
- Build/gitlab-ci/pre-merge/acceptance-application-composer.ymlnew+17 −0
- Build/Scripts/runTests.sh3+76 −6
- Build/Scripts/setupAcceptanceComposer.sh2new+50 −0
- Build/tests/packages/dataset_import/Classes/Command/DatasetImportCommand.phpnew+50 −0
- Build/tests/packages/dataset_import/Configuration/Services.yamlnew+8 −0
- Build/tests/packages/dataset_import/composer.jsonnew+20 −0
- Build/gitlab-ci.yml+2 −0
- typo3/sysext/core/Tests/Acceptance/Application/BackendUser/ListUserCest.php4+72 −28
- typo3/sysext/core/Tests/Acceptance/Application/Extensionmanager/GetExtensionsCest.php+5 −0
- typo3/sysext/core/Tests/Acceptance/Application/Extensionmanager/InstalledExtensionsCest.php+3 −0
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/FalMetadataCest.php+8 −2
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/Inline1nCest.php+10 −0
- typo3/sysext/core/Tests/Acceptance/Application/Frontend/ContentElementsCest.php3+9 −3
- typo3/sysext/core/Tests/Acceptance/Application/Frontend/FormFrameworkCest.php+9 −3
- typo3/sysext/core/Tests/Acceptance/Application/Frontend/FrontendLoginCest.php+9 −3
- typo3/sysext/core/Tests/Acceptance/Application/Frontend/IndexedSearchCest.php+9 −3
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/ImportCest.php+4 −5
- typo3/sysext/core/Tests/Acceptance/Application/InstallTool/AbstractCest.php+13 −7
Show 9 more files
- typo3/sysext/core/Tests/Acceptance/Application/InstallTool/MaintenanceCest.php+2 −0
- typo3/sysext/core/Tests/Acceptance/Application/InstallTool/SettingsCest.php4+8 −2
- typo3/sysext/core/Tests/Acceptance/Application/InstallTool/UpgradeCest.php+2 −0
- typo3/sysext/core/Tests/Acceptance/Application/Redirect/RedirectModuleCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/Scheduler/TasksCest.php+1 −0
- typo3/sysext/core/Tests/Acceptance/Application/Template/TemplateCest.php+4 −0
- typo3/sysext/core/Tests/Acceptance/Support/Extension/ApplicationComposerEnvironment.phpnew+49 −0
- typo3/sysext/core/Tests/Acceptance/Support/Extension/ApplicationEnvironment.php+4 −0
- typo3/sysext/core/Tests/Acceptance/Application.suite.yml+5 −1
Review log 4282
Show 2457 earlier messages
-
Benjamin Franzke uploaded patch set 1 02/17/24, 11:52
-
Benjamin Franzke uploaded patch set 2 02/17/24, 11:56
-
core-ci voted on patch set 1 V -1 02/17/24, 11:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53279
-
core-ci voted on patch set 2 V -1 02/17/24, 11:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53280
-
Benjamin Franzke uploaded patch set 3
V -102/17/24, 12:01 -
core-ci voted on patch set 3 V -1 02/17/24, 12:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53281
-
Benjamin Franzke uploaded patch set 4
V -102/17/24, 14:53 -
core-ci voted on patch set 4 V -1 02/17/24, 15:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53283
-
core-ci commented on patch set 4 02/17/24, 15:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53283
-
Benjamin Franzke uploaded patch set 5
V -102/17/24, 15:11 -
core-ci voted on patch set 4 V -1 02/17/24, 15:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53283
-
core-ci voted on patch set 5 V -1 02/17/24, 15:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53284
-
core-ci commented on patch set 5 02/17/24, 20:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53284
-
core-ci commented on patch set 5 02/17/24, 20:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53284
-
core-ci commented on patch set 5 02/17/24, 21:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53284
-
Benjamin Franzke uploaded patch set 6
V -102/17/24, 21:21 -
core-ci voted on patch set 6 V -1 02/17/24, 21:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53295
-
core-ci commented on patch set 6 02/18/24, 04:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53295
-
Benjamin Franzke uploaded patch set 7
V -102/18/24, 05:06 -
core-ci voted on patch set 7 V -1 02/18/24, 05:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53299
-
Benjamin Franzke uploaded patch set 8
V -102/18/24, 06:00 -
core-ci voted on patch set 8 V -1 02/18/24, 06:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53300
-
Benjamin Franzke uploaded patch set 9
V -102/18/24, 18:19 -
core-ci voted on patch set 9 V -1 02/18/24, 18:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53310
-
Benjamin Franzke uploaded patch set 10
V -102/18/24, 19:54 -
core-ci voted on patch set 10 V -1 02/18/24, 20:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53312
-
Benjamin Franzke uploaded patch set 11
V -102/18/24, 20:23 -
core-ci voted on patch set 11 V +1 02/18/24, 20:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53313
-
Benjamin Franzke uploaded patch set 12
V +102/18/24, 20:38Rebase -
core-ci voted on patch set 12 V -1 02/18/24, 20:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53315
-
core-ci commented on patch set 12 02/18/24, 21:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53315
-
core-ci commented on patch set 12 02/18/24, 21:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53315
-
core-ci voted on patch set 12 V +1 02/18/24, 21:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53315
-
Benjamin Franzke uploaded patch set 13
V +102/18/24, 22:22 -
core-ci voted on patch set 13 V +1 02/18/24, 22:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53317
-
Benjamin Franzke rebased onto patch set 14
V +102/19/24, 16:29 -
core-ci voted on patch set 14 V +1 02/19/24, 16:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53346
-
core-ci commented on patch set 14 02/20/24, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53373
-
Frank Nägler rebased onto patch set 15
V +103/04/24, 07:49 -
Benjamin Franzke wrote 03/04/24, 07:55
Unset private -
core-ci voted on patch set 15 V +1 03/04/24, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53807
-
Frank Nägler rebased onto patch set 16
V +103/05/24, 16:42 -
core-ci voted on patch set 16 V +1 03/05/24, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53969
-
Frank Nägler rebased onto patch set 17
V +103/05/24, 17:50 -
core-ci voted on patch set 17 V +1 03/05/24, 17:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53974
-
Benjamin Franzke uploaded patch set 18
V +103/06/24, 08:55 -
core-ci voted on patch set 18 V -1 03/06/24, 09:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54004
-
Benjamin Franzke uploaded patch set 19
V -103/06/24, 09:24 -
core-ci voted on patch set 19 V +1 03/06/24, 09:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54010
-
Benjamin Franzke uploaded patch set 20
V +103/06/24, 10:32 -
core-ci voted on patch set 20 V +1 03/06/24, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54015
-
Benjamin Franzke uploaded patch set 21
V +103/06/24, 10:45 -
Benjamin Franzke uploaded patch set 22 03/06/24, 10:49
-
core-ci voted on patch set 22 V -1 03/06/24, 10:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54020
-
Benjamin Franzke uploaded patch set 23
V -103/06/24, 10:50 -
core-ci voted on patch set 23 V +1 03/06/24, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54021
-
core-ci voted on patch set 23 V -1 03/06/24, 12:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54030
-
Benjamin Franzke uploaded patch set 24
V -103/06/24, 15:20 -
core-ci voted on patch set 24 V +1 03/06/24, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54045
-
core-ci voted on patch set 24 V -1 03/06/24, 17:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54058
-
core-ci commented on patch set 24 03/06/24, 17:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54058
-
core-ci voted on patch set 24 V +1 03/06/24, 19:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54058
-
Christian Kuhn commented on patch set 24 03/06/24, 19:37
ext_emconf.php:5afaik, ext_emconf is obsolete in composer-mode?ListUserCest.php:47var_dump ;)ListUserCest.php:52"is additionally available" or something? at least some verb is missing ..SettingsCest.php:174maybe just kill in TF?SetupCommand.php:246extract as bugfix pre-patch? -
Benjamin Franzke uploaded patch set 25
V +103/11/24, 09:56 -
Benjamin Franzke commented on patch set 25 03/11/24, 09:59
ext_emconf.php:5ReplyThx, true. Removed.ListUserCest.php:47ReplyDoneListUserCest.php:52ReplyDoneSettingsCest.php:174ReplyFine by me for main-only, but as I'd like to backport this to 12.4 and 11.5, I wouldn't like to require any testing-framework changes right now. Ok with you?SetupCommand.php:246ReplyDone: > 83397: [TASK] Make admin user creation optional in CLI installer | https://review.typo3.org/c/Packages/TYPO3.CMS/+/83397 -
core-ci voted on patch set 25 V +1 03/11/24, 10:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54353
-
Christian Kuhn commented on patch set 25 03/11/24, 11:08
SettingsCest.php:174Replyyeah. an issue in TF about this wouldn't hurt, though - we can then adapt when we find the time. -
Benjamin Franzke commented on patch set 25 03/11/24, 12:49
SettingsCest.php:174Reply -
Christian Kuhn voted on patch set 25 CR +1 V +1 03/11/24, 13:48
-
Stefan Bürk voted on patch set 25 CR +1 V +1 03/11/24, 13:50
-
Benjamin Franzke commented on patch set 25 03/13/24, 07:13
runTests.sh:664This has been copied from the `-s composer` task, but it seems this should be prefixed with `$CORE_ROOT`, as composer is not executed in the root dir and the cache would then be generated in `typo3temp/var/tests/acceptance-composer/.cache`. Change to: ``` -e COMPOSER_CACHE_DIR=${CORE_ROOT}/.cache/composer ```ContentElementsCest.php:35This was racy in v12 backport (for unknown reasons not in main, yet). Add `wait(1)` as in v12? -
Christian Kuhn commented on patch set 25 03/13/24, 09:15
runTests.sh:664Replyyeah, guess so.ContentElementsCest.php:35Replyi don't care too much: if it works in main without wait(), you may leave it out, chances are we need to add it later again, but if you want to be on the safe side, add it. iirc, i added wait() before other doc header drop-downs for the same reason as well. -
Benjamin Franzke uploaded patch set 26
CR +1V +103/16/24, 11:27 -
Benjamin Franzke commented on patch set 26 03/16/24, 11:27
runTests.sh:664ReplyDoneacceptance-application-composer.yml:15`typo3temp/var/log` => `var/log`ContentElementsCest.php:35ReplySkipped for now. -
core-ci voted on patch set 26 V +1 03/16/24, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54620
-
core-ci commented on patch set 26 03/16/24, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54623
-
Christian Kuhn voted on patch set 26 CR +1 V +1 03/17/24, 13:59
-
Simon Schaufelberger commented on patch set 26 03/18/24, 15:45
setupAcceptanceComposer.sh:14Is there a specific reason why you don't run the tests within Build/composer directory? -
Benjamin Franzke commented on patch set 26 03/18/24, 17:03
setupAcceptanceComposer.sh:14ReplyBecause we don't want to mess with this folder in case the developer placed an own testing installation in here. Therefore we use it as a preset but place the installations in typo3temp/var/tests as in classic-mode acceptance tests. -
Stefan Bürk voted on patch set 26 CR +1 V +1 03/18/24, 18:10
-
Benjamin Franzke voted on patch set 26 CR +2 V +2 03/19/24, 05:30
-
Benjamin Franzke merged patch set 27 03/19/24, 05:30