Review main Merged

83027[TASK] Add composer-mode to our acceptance test matrix

Benjamin Franzke CR +2 V +2 Hard +617 −66 updated 03/19/24, 05:30

Commit message

All applicable acceptance tests are now also executed
in composer mode. Tests that check classic-mode specific
functions are excluded and are therefore now tagged
as classic-mode test.

The composer mode instance is generated with our
CLI setup tools, allowing to mimic the realworld
case where a instance is creating via our setup tools
instead of from fixtures (which we still use for classic
mode tests, but try to reducde/avoid for composer mode tests).

The existing existing classic-mode test acceptance test
execution will keep running as-is.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 29

Show 9 more files

Review log 4282

Show 2457 earlier messages
  1. Benjamin Franzke uploaded patch set 1 02/17/24, 11:52

  2. Benjamin Franzke uploaded patch set 2 02/17/24, 11:56

  3. core-ci voted on patch set 1 V -1 02/17/24, 11:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53279

  4. core-ci voted on patch set 2 V -1 02/17/24, 11:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53280

  5. Benjamin Franzke uploaded patch set 3 V -1 02/17/24, 12:01

  6. core-ci voted on patch set 3 V -1 02/17/24, 12:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53281

  7. Benjamin Franzke uploaded patch set 4 V -1 02/17/24, 14:53

  8. core-ci voted on patch set 4 V -1 02/17/24, 15:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53283

  9. core-ci commented on patch set 4 02/17/24, 15:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53283

  10. Benjamin Franzke uploaded patch set 5 V -1 02/17/24, 15:11

  11. core-ci voted on patch set 4 V -1 02/17/24, 15:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53283

  12. core-ci voted on patch set 5 V -1 02/17/24, 15:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53284

  13. core-ci commented on patch set 5 02/17/24, 20:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53284

  14. core-ci commented on patch set 5 02/17/24, 20:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53284

  15. core-ci commented on patch set 5 02/17/24, 21:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53284

  16. Benjamin Franzke uploaded patch set 6 V -1 02/17/24, 21:21

  17. core-ci voted on patch set 6 V -1 02/17/24, 21:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53295

  18. core-ci commented on patch set 6 02/18/24, 04:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53295

  19. Benjamin Franzke uploaded patch set 7 V -1 02/18/24, 05:06

  20. core-ci voted on patch set 7 V -1 02/18/24, 05:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53299

  21. Benjamin Franzke uploaded patch set 8 V -1 02/18/24, 06:00

  22. core-ci voted on patch set 8 V -1 02/18/24, 06:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53300

  23. Benjamin Franzke uploaded patch set 9 V -1 02/18/24, 18:19

  24. core-ci voted on patch set 9 V -1 02/18/24, 18:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53310

  25. Benjamin Franzke uploaded patch set 10 V -1 02/18/24, 19:54

  26. core-ci voted on patch set 10 V -1 02/18/24, 20:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53312

  27. Benjamin Franzke uploaded patch set 11 V -1 02/18/24, 20:23

  28. core-ci voted on patch set 11 V +1 02/18/24, 20:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53313

  29. Benjamin Franzke uploaded patch set 12 V +1 02/18/24, 20:38

    Rebase
  30. core-ci voted on patch set 12 V -1 02/18/24, 20:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53315

  31. core-ci commented on patch set 12 02/18/24, 21:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53315

  32. core-ci commented on patch set 12 02/18/24, 21:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53315

  33. core-ci voted on patch set 12 V +1 02/18/24, 21:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53315

  34. Benjamin Franzke uploaded patch set 13 V +1 02/18/24, 22:22

  35. core-ci voted on patch set 13 V +1 02/18/24, 22:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53317

  36. Benjamin Franzke rebased onto patch set 14 V +1 02/19/24, 16:29

  37. core-ci voted on patch set 14 V +1 02/19/24, 16:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53346

  38. core-ci commented on patch set 14 02/20/24, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53373

  39. Frank Nägler rebased onto patch set 15 V +1 03/04/24, 07:49

  40. Benjamin Franzke wrote 03/04/24, 07:55

    Unset private
  41. core-ci voted on patch set 15 V +1 03/04/24, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53807

  42. Frank Nägler rebased onto patch set 16 V +1 03/05/24, 16:42

  43. core-ci voted on patch set 16 V +1 03/05/24, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53969

  44. Frank Nägler rebased onto patch set 17 V +1 03/05/24, 17:50

  45. core-ci voted on patch set 17 V +1 03/05/24, 17:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53974

  46. Benjamin Franzke uploaded patch set 18 V +1 03/06/24, 08:55

  47. core-ci voted on patch set 18 V -1 03/06/24, 09:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54004

  48. Benjamin Franzke uploaded patch set 19 V -1 03/06/24, 09:24

  49. core-ci voted on patch set 19 V +1 03/06/24, 09:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54010

  50. Benjamin Franzke uploaded patch set 20 V +1 03/06/24, 10:32

  51. core-ci voted on patch set 20 V +1 03/06/24, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54015

  52. Benjamin Franzke uploaded patch set 21 V +1 03/06/24, 10:45

  53. Benjamin Franzke uploaded patch set 22 03/06/24, 10:49

  54. core-ci voted on patch set 22 V -1 03/06/24, 10:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54020

  55. Benjamin Franzke uploaded patch set 23 V -1 03/06/24, 10:50

  56. core-ci voted on patch set 23 V +1 03/06/24, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54021

  57. core-ci voted on patch set 23 V -1 03/06/24, 12:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54030

  1. Benjamin Franzke uploaded patch set 24 V -1 03/06/24, 15:20

  2. core-ci voted on patch set 24 V +1 03/06/24, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54045

  3. core-ci voted on patch set 24 V -1 03/06/24, 17:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54058

  4. core-ci commented on patch set 24 03/06/24, 17:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54058

  5. core-ci voted on patch set 24 V +1 03/06/24, 19:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54058

  6. Christian Kuhn commented on patch set 24 03/06/24, 19:37

    ext_emconf.php:5

    afaik, ext_emconf is obsolete in composer-mode?

    ListUserCest.php:47

    var_dump ;)

    ListUserCest.php:52

    "is additionally available" or something? at least some verb is missing ..

    SettingsCest.php:174

    maybe just kill in TF?

    SetupCommand.php:246

    extract as bugfix pre-patch?
  7. Benjamin Franzke uploaded patch set 25 V +1 03/11/24, 09:56

  8. Benjamin Franzke commented on patch set 25 03/11/24, 09:59

    ext_emconf.php:5 Reply

    Thx, true. Removed.

    ListUserCest.php:47 Reply

    Done

    ListUserCest.php:52 Reply

    Done

    SettingsCest.php:174 Reply

    Fine by me for main-only, but as I'd like to backport this to 12.4 and 11.5, I wouldn't like to require any testing-framework changes right now. Ok with you?

    SetupCommand.php:246 Reply

    Done: > 83397: [TASK] Make admin user creation optional in CLI installer | https://review.typo3.org/c/Packages/TYPO3.CMS/+/83397
  9. core-ci voted on patch set 25 V +1 03/11/24, 10:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54353

  10. Christian Kuhn commented on patch set 25 03/11/24, 11:08

    SettingsCest.php:174 Reply

    yeah. an issue in TF about this wouldn't hurt, though - we can then adapt when we find the time.
  11. Benjamin Franzke commented on patch set 25 03/11/24, 12:49

  12. Christian Kuhn voted on patch set 25 CR +1 V +1 03/11/24, 13:48

  13. Stefan Bürk voted on patch set 25 CR +1 V +1 03/11/24, 13:50

  14. Benjamin Franzke commented on patch set 25 03/13/24, 07:13

    runTests.sh:664

    This has been copied from the `-s composer` task, but it seems this should be prefixed with `$CORE_ROOT`, as composer is not executed in the root dir and the cache would then be generated in `typo3temp/var/tests/acceptance-composer/.cache`. Change to: ``` -e COMPOSER_CACHE_DIR=${CORE_ROOT}/.cache/composer ```

    ContentElementsCest.php:35

    This was racy in v12 backport (for unknown reasons not in main, yet). Add `wait(1)` as in v12?
  15. Christian Kuhn commented on patch set 25 03/13/24, 09:15

    runTests.sh:664 Reply

    yeah, guess so.

    ContentElementsCest.php:35 Reply

    i don't care too much: if it works in main without wait(), you may leave it out, chances are we need to add it later again, but if you want to be on the safe side, add it. iirc, i added wait() before other doc header drop-downs for the same reason as well.
  16. Benjamin Franzke uploaded patch set 26 CR +1 V +1 03/16/24, 11:27

  17. Benjamin Franzke commented on patch set 26 03/16/24, 11:27

    runTests.sh:664 Reply

    Done

    acceptance-application-composer.yml:15

    `typo3temp/var/log` => `var/log`

    ContentElementsCest.php:35 Reply

    Skipped for now.
  18. core-ci voted on patch set 26 V +1 03/16/24, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54620

  19. core-ci commented on patch set 26 03/16/24, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54623

  20. Christian Kuhn voted on patch set 26 CR +1 V +1 03/17/24, 13:59

  21. Simon Schaufelberger commented on patch set 26 03/18/24, 15:45

    setupAcceptanceComposer.sh:14

    Is there a specific reason why you don't run the tests within Build/composer directory?
  22. Benjamin Franzke commented on patch set 26 03/18/24, 17:03

    setupAcceptanceComposer.sh:14 Reply

    Because we don't want to mess with this folder in case the developer placed an own testing installation in here. Therefore we use it as a preset but place the installations in typo3temp/var/tests as in classic-mode acceptance tests.
  23. Stefan Bürk voted on patch set 26 CR +1 V +1 03/18/24, 18:10

  24. Benjamin Franzke voted on patch set 26 CR +2 V +2 03/19/24, 05:30

  25. Benjamin Franzke merged patch set 27 03/19/24, 05:30