Review main Merged

83031[FEATURE] Provide full userdata in password recovery email in ext:backend

Torben Hansen CR +2 V +2 Easy +32 −5 updated 03/10/24, 23:14

Commit message

Currently, the variables `name`, `email`, `language`, `resetLink`
and `username` are available in the template of the password recovery
email for backend users. It is not possible to add custom user
related data from the `be_users` table to the password recovery email.

To enable the possibility to add custom user related data, this
change adds the new variable `userData` to the FluidEmail object,
which contains all userdata of the affected backend user.

Additionally, a superfluous `is_array` check has been removed,
since it is ensured, that the `$users` variable at this point
already is an array.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Guido Schmechel +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Guido Schmechel +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2428

Show 23 earlier messages
  1. Torben Hansen uploaded patch set 1 02/18/24, 18:03

  2. core-ci voted on patch set 1 V +1 02/18/24, 18:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53309

  3. Thomas Hohn commented on patch set 1 02/21/24, 09:19

    PasswordReset.php:145

    Why is the cast need $users should be an array no matter what
  1. Thomas Hohn commented on patch set 1 02/21/24, 09:20

    Just forget it

    PasswordReset.php:145 Reply

    Done
  2. Thomas Hohn voted on patch set 1 CR +1 02/21/24, 09:20

  3. Garvin Hicking commented on patch set 1 02/21/24, 09:21

    PasswordReset.php:131

    IMO we should not expose the "password" column here, to prevent that usage within a fluid template?
  4. Thomas Hohn commented on patch set 1 02/21/24, 09:23

    PasswordReset.php:131 Reply

    It's unset later in the code ..

    PasswordReset.php:145

    The $users should contain at least one element here - right - then the cast is not needed
  5. Garvin Hicking commented on patch set 1 02/21/24, 09:23

    PasswordReset.php:131 Reply

    Ah, I'm sorry, I missed the "unset" later on.

    PasswordReset.php:138

    I think most places in the core now do a "=== []" comparison, maybe adapt to this when it's touched?
  6. Torben Hansen uploaded patch set 2 CR +1 V +1 02/22/24, 14:39

  7. Torben Hansen commented on patch set 1 02/22/24, 14:40

    PasswordReset.php:138 Reply

    Done

    PasswordReset.php:145 Reply

    Done
  8. Thomas Hohn voted on patch set 2 CR +1 02/22/24, 14:42

  9. core-ci voted on patch set 2 V +1 02/22/24, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53447

  10. Garvin Hicking voted on patch set 2 CR +1 V +1 02/22/24, 15:38

  11. Oli Bartsch commented on patch set 2 02/22/24, 17:17

    Feature-103147-ProvideFullUserdataInPasswordRecoveryEmailInExtbackend.rst:16

    Could we mention that this is the `be_users` table? So devs are aware that this includes also any custom field, added to the table.
  12. Torben Hansen uploaded patch set 3 CR +1 V +1 02/23/24, 08:25

  13. Torben Hansen commented on patch set 3 02/23/24, 08:25

    Feature-103147-ProvideFullUserdataInPasswordRecoveryEmailInExtbackend.rst:16 Reply

    Done
  14. Thomas Hohn voted on patch set 3 CR +1 V +1 02/23/24, 08:27

  15. core-ci voted on patch set 3 V +1 02/23/24, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53460

  16. Josef Glatz voted on patch set 3 CR +1 V +1 03/06/24, 16:16

  17. Garvin Hicking commented on patch set 3 CR +1 V +1 03/06/24, 21:58

    Minor ReST nitpicks ;)

    Feature-103147-ProvideFullUserdataInPasswordRecoveryEmailInExtbackend.rst:14

    :html: or maybe just '{userdata}' (backticks)

    Feature-103147-ProvideFullUserdataInPasswordRecoveryEmailInExtbackend.rst:16

    :sql:

    Feature-103147-ProvideFullUserdataInPasswordRecoveryEmailInExtbackend.rst:22

    :html: or backticks
  18. Marvin Buchmann voted on patch set 3 CR +1 V +1 03/08/24, 09:34

  19. Stefan Bürk uploaded patch set 4 CR +1 V +1 03/08/24, 18:28

  20. Stefan Bürk commented on patch set 4 CR +1 V +1 03/08/24, 18:29

    Feature-103147-ProvideFullUserdataInPasswordRecoveryEmailInExtbackend.rst:14 Reply

    Done

    Feature-103147-ProvideFullUserdataInPasswordRecoveryEmailInExtbackend.rst:16 Reply

    Done

    Feature-103147-ProvideFullUserdataInPasswordRecoveryEmailInExtbackend.rst:22 Reply

    Done
  21. core-ci voted on patch set 4 V +1 03/08/24, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54299

  22. Garvin Hicking voted on patch set 4 CR +1 V +1 03/08/24, 18:35

  23. Guido Schmechel voted on patch set 4 CR +1 V +1 03/10/24, 16:03

  24. Benni Mack voted on patch set 4 CR +2 V +2 03/10/24, 23:14

  25. Benni Mack merged patch set 5 03/10/24, 23:14