Review main Merged

83040[TASK] Migrate Localization wizard to MultiStepWizard component

Andreas Kienast CR +2 V +2 Hard +328 −299 updated 02/28/24, 09:13

Commit message

In order to deprecate the inferior Wizard component introduced back in
TYPO3 v7, the Localization wizard is migrated to the MultiStepWizard
component.

In the same run, the opportunity to cleanup the code a bit is taken:
* replace `.then()` callback hell with async/await
* use setting "API" of MSW instead of local properties
* steps that don't allow interaction are skipped from composition

Also, some minor quirks in MSW are fixed without doing major
refactorings:
* `forceSelection` is checked and enforced before running callbacks that
  may unlock any buttons, otherwise leading to a unresolvable situation
* the "previous" button is now automatically (un)locked, depending on
  whether there are previous steps
* the content of the slide that is slid to is reset as it may have been
  altered in a slide callback

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Nedbal +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Nedbal +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1117

  1. Andreas Kienast uploaded patch set 1 02/20/24, 08:55

  2. Andreas Kienast updated the commit message in patch set 2 02/20/24, 08:58

  3. core-ci voted on patch set 1 V +1 02/20/24, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53359

  4. core-ci voted on patch set 2 V -1 02/20/24, 09:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53360

  5. core-ci voted on patch set 2 V +1 02/20/24, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53360

  6. Andreas Kienast uploaded patch set 3 V +1 02/21/24, 13:43

  7. core-ci voted on patch set 3 V +1 02/21/24, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53426

  8. Andreas Nedbal voted on patch set 3 CR +1 V +1 02/23/24, 00:18

  9. Oli Bartsch voted on patch set 3 V -1 02/23/24, 10:43

  10. Andreas Kienast commented on patch set 3 CR -1 02/23/24, 11:26

    on it
  11. Andreas Kienast uploaded patch set 4 CR +1 V +1 02/23/24, 11:35

  12. Andreas Kienast uploaded patch set 5 02/23/24, 11:37

  13. core-ci voted on patch set 4 V +1 02/23/24, 11:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53478

  14. core-ci voted on patch set 5 V +1 02/23/24, 11:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53479

  15. Andreas Nedbal voted on patch set 5 CR +1 V +1 02/27/24, 10:09

  16. Oli Bartsch voted on patch set 5 CR +2 V +2 02/28/24, 09:13

  17. Oli Bartsch merged patch set 6 02/28/24, 09:13