Review main Merged

83051[TASK] Clean up legacy cache_treelist leftovers

Sascha Nowak CR +2 V +2 Hard +24 −452 updated 02/21/24, 10:24

Commit message

Using cache_treelist has been avoided with #103139
since it was broken. v13 now goes ahead and removes
the clearing logic and the table itself.

Note the PageRepository method that formerlly used
that cache would be a great target for a (first) CTE
to structurally enhance performance. v13 may see
patches in this area.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 8

Review log 1318

  1. Sascha Nowak uploaded patch set 1 02/21/24, 06:06

  2. core-ci voted on patch set 1 V -1 02/21/24, 06:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53394

  3. Andreas Kienast commented on patch set 1 02/21/24, 07:29

    Wrong ticket

    Important-103165-Remove-treelist-cache.rst:18

    That's an unsupported tag
  4. Sascha Nowak uploaded patch set 2 V -1 02/21/24, 08:14

  5. Sascha Nowak commented on patch set 2 02/21/24, 08:15

    Reply

    This was an explicit wish from @lolli@schwarzbu.ch and @benni@typo3.org to remove the cache for main, 12 and remove the rest of the code only in main.

    Reply

    Done

    Important-103165-Remove-treelist-cache.rst:18 Reply

    Done
  6. core-ci voted on patch set 2 V -1 02/21/24, 08:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53403

  7. Christian Kuhn commented on patch set 2 CR -1 02/21/24, 09:24

    on it.
  8. Christian Kuhn commented on patch set 2 02/21/24, 09:37

    PageRepositoryTest.php:550

    context init can be skipped.
  9. Christian Kuhn uploaded patch set 3 CR -1 V -1 02/21/24, 09:59

  10. Christian Kuhn updated the commit message in patch set 4 02/21/24, 10:04

  11. core-ci voted on patch set 3 V -1 02/21/24, 10:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53409

  12. Christian Kuhn updated the commit message in patch set 5 02/21/24, 10:05

  13. Christian Kuhn uploaded patch set 6 02/21/24, 10:06

  14. core-ci voted on patch set 4 V -1 02/21/24, 10:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53410

  15. core-ci voted on patch set 6 V +1 02/21/24, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53412

  16. Christian Kuhn voted on patch set 6 CR +1 V +1 02/21/24, 10:18

  17. Stefan Bürk voted on patch set 6 CR +2 V +2 02/21/24, 10:24

  18. Stefan Bürk merged patch set 7 02/21/24, 10:24