Review main Merged

83054[TASK] Migrate input-group-addon to input-group-text

Benjamin Kott CR +2 V +2 Normal +37 −42 updated 02/21/24, 09:04

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 25

Show 5 more files

Review log 79

  1. Benjamin Kott uploaded patch set 1 02/21/24, 08:27

  2. Andreas Kienast commented on patch set 1 CR -1 02/21/24, 08:33

    `Build/Sources/Sass/typo3/_main_form.scss` still defined this
  3. core-ci voted on patch set 1 V +1 02/21/24, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53404

  4. Benjamin Kott uploaded patch set 2 CR -1 V +1 02/21/24, 08:36

  5. Benjamin Kott commented on patch set 2 02/21/24, 08:36

    Reply

    done
  6. core-ci voted on patch set 2 V +1 02/21/24, 08:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53406

  7. Andreas Kienast voted on patch set 2 CR +1 V +1 02/21/24, 08:44

  8. Benjamin Franzke commented on patch set 2 CR +2 V +2 02/21/24, 09:04

    _main_form.scss:41

    Should be reconsidered in general, as this'll produce too wide text-groups for ConstantEditorFields of type wrap.
  9. Benjamin Franzke merged patch set 3 02/21/24, 09:04