83054[TASK] Migrate input-group-addon to input-group-text
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 25
- Build/Sources/Sass/typo3/_main_form.scss1+1 −1
- Build/Sources/Sass/_legacy.scss+2 −7
- Build/Sources/TypeScript/backend/form-engine/element/select-tree-toolbar.ts+1 −1
- Build/Sources/TypeScript/backend/localization.ts+1 −1
- Build/Sources/TypeScript/install/renderable/offset-group.ts+2 −2
- typo3/sysext/backend/Classes/Form/Element/GroupElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/InputSlugElement.php+2 −2
- typo3/sysext/backend/Classes/Form/Element/LinkElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/SelectSingleElement.php+1 −1
- typo3/sysext/backend/Resources/Private/Templates/Page/NewPages.html+1 −1
- typo3/sysext/backend/Resources/Private/Templates/ColumnSelector.html+1 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+5 −5
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/select-tree-toolbar.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/localization.js+1 −1
- typo3/sysext/filelist/Resources/Private/Templates/File/ReplaceFile.html+1 −1
- typo3/sysext/install/Resources/Private/Templates/Settings/ExtensionConfigurationGetContent.html+1 −1
- typo3/sysext/install/Resources/Private/Templates/Settings/LocalConfigurationGetContent.html+1 −1
- typo3/sysext/install/Resources/Private/Templates/Settings/SystemMaintainer.html+1 −1
- typo3/sysext/install/Resources/Private/Templates/Upgrade/UpgradeDocsGetContent.html+2 −2
- typo3/sysext/install/Resources/Public/JavaScript/renderable/offset-group.js+2 −2
Show 5 more files
- typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php+1 −1
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Icons.html+1 −1
- typo3/sysext/tstemplate/Resources/Private/Partials/ConstantEditorFields.html+2 −2
- typo3/sysext/tstemplate/Resources/Private/Templates/ActiveEdit.html+3 −3
- typo3/sysext/workspaces/Resources/Private/Partials/WorkingTable.html+1 −1
Review log 79
-
Benjamin Kott uploaded patch set 1 02/21/24, 08:27
-
Andreas Kienast commented on patch set 1 CR -1 02/21/24, 08:33
`Build/Sources/Sass/typo3/_main_form.scss` still defined this -
core-ci voted on patch set 1 V +1 02/21/24, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53404
-
Benjamin Kott uploaded patch set 2
CR -1V +102/21/24, 08:36 -
Benjamin Kott commented on patch set 2 02/21/24, 08:36
Reply
done -
core-ci voted on patch set 2 V +1 02/21/24, 08:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53406
-
Andreas Kienast voted on patch set 2 CR +1 V +1 02/21/24, 08:44
-
Benjamin Franzke commented on patch set 2 CR +2 V +2 02/21/24, 09:04
_main_form.scss:41Should be reconsidered in general, as this'll produce too wide text-groups for ConstantEditorFields of type wrap. -
Benjamin Franzke merged patch set 3 02/21/24, 09:04