Review main Merged

83078[TASK] Use phpunit attributes over annotations

Christian Kuhn CR +2 V +2 Impossible +6630 −14576 updated 02/23/24, 13:52

Commit message

phpunit 11 deprecates annotations like `@test` and
`@dataProvider` in favor of their attribute counterparts.

We'll adapt core main & v12 to keep v12 backports
simple. The patch takes care of Tests/Unit and
Tests/UnitDeprecated, functional test need some
additional quirk for the test splitter to
continue to work.

> composer req --dev rector/rector
> wget https://forge.typo3.org/attachments/download/38273/rector.php
> find typo3/ -name \*Test.php | grep Tests/Unit | xargs bin/rector process
> rm rector.php
> composer rem --dev rector/rector

Minor manual adaption in ErrorHandlerTest.php and
GeneralUtilityTest.php, and `runTests.sh -s cglGit`.

Number of executed unit tests and unitDeprecated tests
should stay the same.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 700

Show 680 more files

Review log 1216

  1. Christian Kuhn uploaded patch set 1 02/22/24, 15:17

  2. core-ci voted on patch set 1 V -1 02/22/24, 15:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53448

  3. Christian Kuhn uploaded patch set 2 V -1 02/23/24, 12:52

  4. core-ci voted on patch set 2 V +1 02/23/24, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53489

  5. Andreas Kienast voted on patch set 2 CR +1 V +1 02/23/24, 13:12

  6. Stefan Bürk voted on patch set 2 CR +1 V +1 02/23/24, 13:14

  7. Christian Kuhn uploaded patch set 3 CR +1 V +1 02/23/24, 13:36

  8. Andreas Kienast voted on patch set 3 CR +1 V +1 02/23/24, 13:38

  9. Stefan Bürk voted on patch set 3 CR +1 V +1 02/23/24, 13:38

  10. Christian Kuhn uploaded patch set 4 CR +1 V +1 02/23/24, 13:39

  11. Stefan Bürk voted on patch set 4 CR +1 V +1 02/23/24, 13:42

  12. core-ci voted on patch set 3 V -1 02/23/24, 13:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53497

  13. core-ci voted on patch set 4 V +1 02/23/24, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53498

  14. Andreas Kienast voted on patch set 4 CR +1 V +1 02/23/24, 13:49

  15. Christian Kuhn voted on patch set 4 CR +2 V +2 02/23/24, 13:52

  16. Christian Kuhn merged patch set 5 02/23/24, 13:52