83080[DOCS] Correct field name in reaction's example
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1923
-
TYPO3com uploaded patch set 1 02/22/24, 18:04
-
Garvin Hicking commented on patch set 1 02/22/24, 18:09
Thanks for the contribution! this tx_... schema is actually a convention that is followed through in all of the documentation, when extbase extensions are involved, like in the caption here. Could you otherwise describe more in depth why this notation is not suitable for you, maybe I'm misunderstanding something? -
core-ci voted on patch set 1 V +1 02/22/24, 18:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53452
-
Chris Müller commented on patch set 1 02/22/24, 18:11
Reply
The fix is right, the second argument expects the TCA field. The table name is given in the third argument in the array. -
Chris Müller updated the commit message in patch set 2
V +102/22/24, 18:12 -
core-ci voted on patch set 2 V +1 02/22/24, 18:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53453
-
Chris Müller voted on patch set 2 CR +1 V +1 02/22/24, 18:20
-
Daniel Schöne commented on patch set 2 02/22/24, 19:34
Hi, I proposed the change. As Chris already mentioned: the 2nd argument is the field, the option should be appended to. Using "tx_myextension_domain_model_mytable" results in an exception, as this field does not exist in sys_reaction. -
Garvin Hicking commented on patch set 2 CR +1 V +1 02/22/24, 19:54
Reply
AcknowledgedReply
Thanks, now I see it! sorry! 😅 -
Daniel Schöne commented on patch set 2 CR +1 02/22/24, 20:08
👍 thanks for reviewing -
Daniel Schöne voted on patch set 2 V +1 02/22/24, 20:14
-
Oli Bartsch commented on patch set 2 CR -1 02/23/24, 13:29
Index.rst:160While already on it. Let's use speaking array keys. -
Oli Bartsch uploaded patch set 3
CR +1V +102/23/24, 13:31 -
Oli Bartsch commented on patch set 3 CR +1 V +1 02/23/24, 13:34
Index.rst:160ReplyDone -
core-ci voted on patch set 3 V +1 02/23/24, 13:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53495
-
Garvin Hicking commented on patch set 3 CR +1 V +1 02/23/24, 14:01
Nice change indeed! -
Oli Bartsch voted on patch set 3 CR +2 V +2 02/23/24, 14:09
-
Oli Bartsch merged patch set 4 02/23/24, 14:18
-
Daniel Schöne commented on patch set 4 02/23/24, 15:12
Index.rst:160opening parenthesis missingIndex.rst:161opening parenthesis missing -
Daniel Schöne commented on patch set 4 02/23/24, 15:14
Index.rst:160Replysorry singe quoteIndex.rst:161Replyparenthesis -
Garvin Hicking commented on patch set 4 02/23/24, 17:19
Index.rst:161ReplyOh damn, didn't spot that. This patch has been merged already. Would you want to create a follow-up patch to address the proper notation? Else I can offer to do that legwork. ;) -
Daniel Schöne commented on patch set 4 02/23/24, 17:32
Added a patch via github. See https://review.typo3.org/c/Packages/TYPO3.CMS/+/83116 Didn't use gerrit for years, so that's the easiest way for me 😄 -
Daniel Schöne commented on patch set 4 02/23/24, 19:10
Index.rst:160ReplyDoneIndex.rst:161ReplyDone