Review main Merged

83084[TASK] Ensure using symfony container in tests

Oli Bartsch CR +2 V +2 Normal +40 −50 updated 02/23/24, 13:07

Commit message

A couple of tests are adding services to a
container instance. Since the `ContainerInterface`
does not define the used `set()` method, the
tests are adjusted to explicitly require the
symfony service container, which provides
mentioned `set()` method.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 27

Show 7 more files

Review log 911

  1. Oli Bartsch uploaded patch set 1 02/23/24, 09:45

  2. core-ci voted on patch set 1 V -1 02/23/24, 09:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53466

  3. Oli Bartsch uploaded patch set 2 V -1 02/23/24, 10:01

  4. core-ci voted on patch set 2 V +1 02/23/24, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53469

  5. Benjamin Franzke voted on patch set 2 CR +1 V +1 02/23/24, 10:17

  6. Andreas Kienast commented on patch set 2 CR -1 02/23/24, 10:56

    There are a few cases left in `typo3/sysext/core/Tests/Functional/Log/LoggerAwareChannelTest.php` and `typo3/sysext/core/Tests/Functional/Log/LoggerAwareChannelTest.php`
  7. Andreas Kienast commented on patch set 2 02/23/24, 10:57

    Clarified. It's **only** about the cases where `->set()` is called afterwards.
  8. Andreas Kienast voted on patch set 2 CR +1 V +1 02/23/24, 10:57

  9. Oliver Klee voted on patch set 2 CR +1 V +1 02/23/24, 12:04

  10. Oli Bartsch voted on patch set 2 CR +2 V +2 02/23/24, 13:07

  11. Oli Bartsch merged patch set 3 02/23/24, 13:07