83084[TASK] Ensure using symfony container in tests
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Oliver Klee +1
- Andreas Kienast +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Oliver Klee +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 27
- Build/phpstan/phpstan-baseline.neon+0 −10
- typo3/sysext/backend/Tests/Functional/Controller/Page/TreeControllerTest.php+1 −1
- typo3/sysext/backend/Tests/Functional/Controller/BackendControllerTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Configuration/FlexForm/FlexFormToolsTest.php+5 −5
- typo3/sysext/core/Tests/Functional/Domain/Repository/PageRepositoryTest.php+2 −2
- typo3/sysext/core/Tests/Functional/Imaging/IconFactoryTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Mail/MailerTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Package/Event/PackageInitializationEventTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Resource/OnlineMedia/Processing/PreviewProcessingTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Resource/DefaultUploadFolderResolverTest.php+2 −2
- typo3/sysext/dashboard/Tests/Functional/WidgetRegistryTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Configuration/FrontendConfigurationManagerTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Validation/Validator/CollectionValidatorTest.php+2 −2
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/SelectViewHelperTest.php+4 −4
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentContentObjectTest.php+1 −1
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+4 −4
- typo3/sysext/install/Tests/Functional/ViewHelpers/Format/PhpErrorCodeViewHelperTest.php+1 −1
- typo3/sysext/lowlevel/Tests/Functional/ConfigurationModuleProvider/GlobalVariableProviderTest.php+1 −1
- typo3/sysext/redirects/Tests/Functional/Controller/ManagementControllerTest.php+1 −1
- typo3/sysext/redirects/Tests/Functional/EventListener/AddPageTypeZeroSourceTest.php+1 −1
Show 7 more files
- typo3/sysext/redirects/Tests/Functional/EventListener/AddPlainSlugReplacementSourceTest.php+1 −1
- typo3/sysext/redirects/Tests/Functional/RedirectUpdate/SlugRedirectChangeItemFactoryTest.php+1 −1
- typo3/sysext/redirects/Tests/Functional/Service/RedirectServiceTest.php+1 −1
- typo3/sysext/redirects/Tests/Functional/Service/SlugServiceTest.php+2 −2
- typo3/sysext/rte_ckeditor/Tests/Functional/RecordList/Controller/BrowseLinksControllerTest.php+1 −1
- typo3/sysext/seo/Tests/Functional/Canonical/CanonicalGeneratorTest.php+1 −1
- typo3/sysext/workspaces/Tests/Functional/Hook/DataHandlerHookTest.php+1 −1
Review log 911
-
Oli Bartsch uploaded patch set 1 02/23/24, 09:45
-
core-ci voted on patch set 1 V -1 02/23/24, 09:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53466
-
Oli Bartsch uploaded patch set 2
V -102/23/24, 10:01 -
core-ci voted on patch set 2 V +1 02/23/24, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53469
-
Benjamin Franzke voted on patch set 2 CR +1 V +1 02/23/24, 10:17
-
Andreas Kienast commented on patch set 2 CR -1 02/23/24, 10:56
There are a few cases left in `typo3/sysext/core/Tests/Functional/Log/LoggerAwareChannelTest.php` and `typo3/sysext/core/Tests/Functional/Log/LoggerAwareChannelTest.php` -
Andreas Kienast commented on patch set 2 02/23/24, 10:57
Clarified. It's **only** about the cases where `->set()` is called afterwards. -
Andreas Kienast voted on patch set 2 CR +1 V +1 02/23/24, 10:57
-
Oliver Klee voted on patch set 2 CR +1 V +1 02/23/24, 12:04
-
Oli Bartsch voted on patch set 2 CR +2 V +2 02/23/24, 13:07
-
Oli Bartsch merged patch set 3 02/23/24, 13:07