Review 12.4 Merged

83088[TASK] Ensure using symfony container in tests

Oli Bartsch CR +2 V +2 Normal +31 −46 updated 02/23/24, 13:08

Commit message

A couple of tests are adding services to a
container instance. Since the `ContainerInterface`
does not define the used `set()` method, the
tests are adjusted to explicitly require the
symfony service container, which provides
mentioned `set()` method.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 22

Show 2 more files

Review log 34

  1. Oli Bartsch uploaded patch set 1 02/23/24, 12:42

  2. core-ci voted on patch set 1 V +1 02/23/24, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53483

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 02/23/24, 13:07

  4. Oli Bartsch merged patch set 2 02/23/24, 13:08