Review main Merged

83090[BUGFIX] Allow maxitems=1 for TCA type category

Markus Klein CR +2 V +2 Easy +4 −33 updated 02/28/24, 12:47

Commit message

In relation mode "manyToMany" it is okay to have
a limit of one.

Code-wise the FlexForm code is slightly simplified
as there is no support for the "manytoMany" case.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Josef Glatz +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Josef Glatz +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 79

  1. Markus Klein uploaded patch set 1 02/23/24, 13:53

  2. core-ci voted on patch set 1 V -1 02/23/24, 13:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53499

  3. Markus Klein uploaded patch set 2 V -1 02/23/24, 14:11

  4. core-ci voted on patch set 2 V +1 02/23/24, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53503

  5. Josef Glatz voted on patch set 2 CR +1 V +1 02/23/24, 14:45

  6. Oli Bartsch commented on patch set 2 02/28/24, 11:00

    TcaPreparation.php:119

    I though about this but did not come up with a reason to not allow maxitems=1 for oneToMany. IMO this should also be possible like for manyToMany. Or do I miss something?
  7. Markus Klein commented on patch set 2 02/28/24, 12:26

    TcaPreparation.php:119 Reply

    Since this is CSV storage, it would not matter indeed. But I support the opinion here that it is okay to force the developer to use the correction relation type. There isn't a problem for upgrades, since category-CSV storage was not possible. Hence, I would keep it that way.
  8. Oli Bartsch commented on patch set 2 CR +2 V +2 02/28/24, 12:47

    TcaPreparation.php:119 Reply

    Acknowledged
  9. Oli Bartsch merged patch set 3 02/28/24, 12:47