Review 12.4 Merged

83094[BUGFIX] Preserve ordering of prefixed CKEditor5 CSS stylesheets

Benjamin Franzke CR +2 V +2 Easy +22 −12 updated 02/23/24, 09:22

Commit message

When CKEditor5 `contentsCss` configuration options references multiple
CSS, respective `fetch()` requests may finish in non-sequential order,
depending on server load and file size, causing intended CSS ordering
to break.

Ensure sequential ordering by waiting for all promises to be settled
via `Promise.allSettled()`.
It is guaranteed to return the promise status and values "in the order
of the promises passed, regardless of completion order":
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/allSettled#return_value

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Benjamin Franzke commented on patch set 1 02/23/24, 09:12

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/23/24, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53461

  3. Benjamin Franzke voted on patch set 1 CR +2 V +2 02/23/24, 09:21

  4. Benjamin Franzke merged patch set 2 02/23/24, 09:22