Review main Merged

83114[BUGFIX] Always set `action` argument for action ViewHelpers

Oli Bartsch CR +2 V +2 Easy +19 −19 updated 02/23/24, 21:13

Commit message

A couple of places (mostly paginations) are
using the action ViewHelpers without providing
the `action` argument. Those links will therefore
fall back to the default action, which might be
wrong e.g. in the backend user group listing.

To preserve the current action on paginating,
the corresponding action is now always set.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Markus Klein +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Markus Klein +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 7

Review log 78

  1. Oli Bartsch uploaded patch set 1 02/23/24, 15:04

  2. core-ci voted on patch set 1 V +1 02/23/24, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53508

  3. Markus Klein voted on patch set 1 CR +1 02/23/24, 15:15

  4. Markus Klein voted on patch set 1 V +1 02/23/24, 15:16

  5. Stefan Bürk commented on patch set 1 CR -1 02/23/24, 19:57

    checking ...
  6. Stefan Bürk voted on patch set 1 CR +1 V +1 02/23/24, 20:05

  7. Oli Bartsch voted on patch set 1 CR +2 V +2 02/23/24, 21:13

  8. Oli Bartsch merged patch set 2 02/23/24, 21:13