Review main Merged

83139[TASK] Require nikic/php-parser:^5.0.1

Christian Kuhn CR +2 V +2 Hard +137 −199 updated 02/26/24, 14:48

Commit message

Major version upgrade from v4. Unblocks phpunit 11.
Adapt various Build/ scripts and the extension scanner.

> composer req nikic/php-parser:^5.0.1
> composer req nikic/php-parser:^5.0.1 -d typo3/sysext/install --no-update

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 54

Show 34 more files

Review log 1117

  1. Christian Kuhn uploaded patch set 1 02/26/24, 13:33

  2. Christian Kuhn updated the commit message in patch set 2 02/26/24, 13:34

  3. core-ci voted on patch set 1 V -1 02/26/24, 13:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53615

  4. core-ci voted on patch set 2 V -1 02/26/24, 13:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53616

  5. Christian Kuhn uploaded patch set 3 V -1 02/26/24, 13:39

  6. core-ci voted on patch set 3 V -1 02/26/24, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53617

  7. Christian Kuhn uploaded patch set 4 V -1 02/26/24, 14:13

  8. core-ci voted on patch set 4 V -1 02/26/24, 14:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53618

  9. Christian Kuhn uploaded patch set 5 V -1 02/26/24, 14:19

  10. Christian Kuhn uploaded patch set 6 02/26/24, 14:23

  11. core-ci voted on patch set 5 V -1 02/26/24, 14:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53619

  12. core-ci voted on patch set 6 V +1 02/26/24, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53620

  13. Oliver Klee voted on patch set 6 V +1 02/26/24, 14:39

  14. Oliver Klee voted on patch set 6 CR +1 02/26/24, 14:41

  15. Stefan Bürk voted on patch set 6 CR +1 V +1 02/26/24, 14:46

  16. Benni Mack commented on patch set 6 CR +2 V +2 02/26/24, 14:48

    Thanks for taking care!
  17. Benni Mack merged patch set 7 02/26/24, 14:48