Review main Merged

83150[TASK] Avoid phpunit addMethods()

Christian Kuhn CR +2 V +2 Hard +181 −357 updated 02/27/24, 17:40

Commit message

phpunit 11 deprecates addMethods() on mocks.
There are various solutions:

* Use onlyMethods([]) instead of
  addMethods(['dummy']) to "mock nothing"
* Remove a couple of calls that were bogus
  in the first place
* Turn calls into mocks of interfaces
* Turn calls into mocks of fixture classes
* Instantiate a subject with new()

Also have the one or the other minor cleanup as drive-by.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 24

Show 4 more files

Review log 67

  1. Christian Kuhn uploaded patch set 1 02/27/24, 17:23

  2. core-ci voted on patch set 1 V +1 02/27/24, 17:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53647

  3. Oliver Klee voted on patch set 1 V +1 02/27/24, 17:29

  4. Stefan Bürk voted on patch set 1 CR +1 V +1 02/27/24, 17:33

  5. Oliver Klee voted on patch set 1 CR +1 02/27/24, 17:33

  6. Anja Leichsenring voted on patch set 1 CR +2 V +2 02/27/24, 17:40

  7. Anja Leichsenring merged patch set 2 02/27/24, 17:40