Review main Merged

83155[TASK] Update invalid test data providers

Christian Kuhn CR +2 V +2 Hard +392 −406 updated 04/15/24, 19:18

Commit message

Phpunit 11 is a bit more picky with data providers:
If single data sets "name" their arguments, they
must match to the consuming test argument names,
or a PHP warning is raised.

The patch adapts data providers or test method
arguments to deal with this.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 36

Show 16 more files

Review log 79

  1. Christian Kuhn uploaded patch set 1 02/28/24, 09:11

  2. core-ci voted on patch set 1 V +1 02/28/24, 09:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53675

  3. Christian Kuhn updated the commit message in patch set 2 V +1 02/28/24, 09:19

  4. core-ci voted on patch set 2 V +1 02/28/24, 09:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53676

  5. Anja Leichsenring voted on patch set 2 CR +1 V +1 02/28/24, 09:32

  6. Oliver Klee voted on patch set 2 CR +1 V +1 02/28/24, 09:36

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 02/28/24, 09:44

  8. Christian Kuhn merged patch set 3 02/28/24, 09:44

  9. Stefan Bürk commented on patch set 3 04/15/24, 19:18