83160[TASK] Avoid phpunit getMockForAbstractClass()
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/form/Tests/Unit/Domain/Finishers/Fixtures/AbstractFinisherFixture.phpnew+57 −0
- typo3/sysext/form/Tests/Unit/Domain/Finishers/AbstractFinisherTest.php+50 −304
- typo3/sysext/form/Tests/Unit/Domain/FormElements/Fixtures/AbstractSectionFixture.phprenamed+1 −16
- typo3/sysext/form/Tests/Unit/Domain/FormElements/AbstractSectionTest.php+36 −113
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/Fixtures/AbstractMenuContentObjectFixture.phpnew+52 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+60 −112
- typo3/sysext/frontend/Tests/Unit/Typolink/Fixtures/AbstractTypolinkBuilderFixture.php2new+40 −0
- typo3/sysext/frontend/Tests/Unit/Typolink/AbstractTypolinkBuilderTest.php+24 −95
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/AbstractCoreMatcherFixture.php4new+35 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/AbstractCoreMatcherTest.php+16 −16
Review log 1215
-
Christian Kuhn uploaded patch set 1 02/28/24, 13:30
-
Christian Kuhn uploaded patch set 2 02/28/24, 13:33
-
core-ci voted on patch set 1 V +1 02/28/24, 13:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53686
-
core-ci voted on patch set 2 V +1 02/28/24, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53687
-
Oliver Klee commented on patch set 2 02/28/24, 13:56
AbstractCoreMatcherFixture.php:31I'd prefer to have native type (param and return) declarations for all fixture subclasses as much as possible: The stricter, the better, as this helps both static type analysis as well as detect unexpected types at runtime. -
Oliver Klee commented on patch set 2 02/28/24, 13:57
AbstractCoreMatcherFixture.php:31Reply(even if the corresponding parent classes do not have strict types in all places yet) -
Christian Kuhn commented on patch set 2 02/28/24, 14:01
AbstractTypolinkBuilderFixture.php:31ReplyDoneAbstractCoreMatcherFixture.php:31Replyi prefer to keep that for now to keep the classes in sync. -
Christian Kuhn uploaded patch set 3
V +102/28/24, 14:01 -
Oliver Klee voted on patch set 3 CR +1 V +1 02/28/24, 14:05
-
Christian Kuhn commented on patch set 3 02/28/24, 14:06
AbstractCoreMatcherFixture.php:31Replymaybe some more words: i think it's benefitial when those 'make stuff public' fixtures deviate from the SuT as little as possible: imho, we should only change signatures when the SuT is changed as well. -
Anja Leichsenring voted on patch set 3 CR +2 V +2 02/28/24, 14:07
-
core-ci voted on patch set 3 V +1 02/28/24, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53688
-
Stefan Bürk voted on patch set 3 CR +1 V +1 02/28/24, 14:07
-
Christian Kuhn voted on patch set 3 CR +2 V +2 02/28/24, 14:08
-
Christian Kuhn merged patch set 4 02/28/24, 14:08
AbstractTypolinkBuilderFixture.php:31