Review 12.4 Merged

83172[BUGFIX] Make page tree workspace color important

Christian Kuhn CR +2 V +2 Easy +5 −0 updated 03/02/24, 08:59

Commit message

The page tree can be colored using user TS, example
for page uid '65' and all pages below:

`options.pageTree.backgroundColor.65 = #41afd8`

If a record is changed in workspaces, that page is
also colored. In v11, the 'ws changed' color has a
higher priority than the custom background color,
which is good UX wise. This stopped working in v12
with #97344.

v13 is not affected since the "color approach" has been
changed. The v12 patch is to re-add the "ws changed" color
as "fill" with an !important, to force overriding the
svg inline style of the custom background color, similar
to v11.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1014

  1. Christian Kuhn uploaded patch set 1 03/01/24, 12:08

  2. Christian Kuhn updated the commit message in patch set 2 03/01/24, 12:09

  3. core-ci voted on patch set 1 V +1 03/01/24, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53750

  4. core-ci voted on patch set 2 V +1 03/01/24, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53751

  5. Benni Mack updated the commit message in patch set 3 V +1 03/01/24, 15:30

  6. Benni Mack voted on patch set 3 CR +1 V +1 03/01/24, 15:30

  7. Andreas Kienast updated the commit message in patch set 4 CR +1 V +1 03/01/24, 15:33

  8. Andreas Kienast voted on patch set 4 CR +1 03/01/24, 15:33

  9. Benni Mack voted on patch set 4 CR +1 V +1 03/01/24, 15:34

  10. core-ci voted on patch set 3 V +1 03/01/24, 15:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53761

  11. Andreas Kienast voted on patch set 4 V +1 03/01/24, 15:36

  12. core-ci voted on patch set 4 V +1 03/01/24, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53762

  13. Christian Kuhn voted on patch set 4 CR +2 V +2 03/02/24, 08:59

  14. Christian Kuhn merged patch set 5 03/02/24, 08:59