Review main Merged

83181[TASK] Apply preg_replace over str_replace for splitted bparams string

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 03/04/24, 18:15

Commit message

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1316

  1. Oli Bartsch uploaded patch set 1 03/03/24, 12:42

  2. core-ci voted on patch set 1 V +1 03/03/24, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53790

  3. Oliver Klee commented on patch set 1 CR -1 03/03/24, 13:57

    FileBrowser.php:65

    If I understand https://www.php.net/manual/en/function.ltrim.php correctly, this will remove all "a", "l"s, "d" etc. from the start of the string (in any order), not only the prefix "allowed=". So this probably is not what the previous version of the code intended. Am I missing something here?
  4. Oli Bartsch uploaded patch set 2 CR -1 V +1 03/03/24, 14:12

  5. Oli Bartsch commented on patch set 2 03/03/24, 14:15

    FileBrowser.php:65 Reply

    You're right. Changed it to preg_replace with limit.
  6. core-ci voted on patch set 2 V +1 03/03/24, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53792

  7. Oliver Klee updated the commit message in patch set 3 V +1 03/03/24, 16:28

  8. Oliver Klee voted on patch set 3 CR +1 03/03/24, 16:29

  9. Oliver Klee commented on patch set 3 CR 0 03/03/24, 16:30

    To me, this looks like a fix for an actual bug. I propose adding tests for it and backporting to 12.4.
  10. core-ci voted on patch set 3 V +1 03/03/24, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53796

  11. Oli Bartsch commented on patch set 3 03/03/24, 22:46

    Reply

    Actually, this is just a precaution, taken from this patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/83180, which only targets 12.4.
  12. Oliver Klee commented on patch set 3 CR +1 03/04/24, 09:26

    Reply

    Acknowledged
  13. Jochen Roth voted on patch set 3 CR +1 V +1 03/04/24, 17:19

  14. Stefan Bürk voted on patch set 3 CR +1 V +1 03/04/24, 18:13

  15. Oli Bartsch voted on patch set 3 CR +2 V +2 03/04/24, 18:15

  16. Oli Bartsch merged patch set 4 03/04/24, 18:15