Review main Abandoned

83182[BUGFIX] Re-add tree item customization with css class

Christoph Lehmann CR 0 V 0 Easy +12 −2 updated 03/03/24, 20:08

Commit message

Before change 81411 tree items could be customized with an additional css class. This re-adds the possibility because it's a requirement for 3rd party extensions.

Before the node item attribute was named "class", which is now "additionalCssClass".

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 9

Review log 57

  1. Christoph Lehmann uploaded patch set 1 03/03/24, 18:56

  2. core-ci voted on patch set 1 V +1 03/03/24, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53799

  3. Christoph Lehmann updated the commit message in patch set 2 V +1 03/03/24, 19:07

  4. core-ci voted on patch set 2 V +1 03/03/24, 19:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53800

  5. Benjamin Kott commented on patch set 2 CR -2 03/03/24, 19:26

    CSS classes are only used to set colors or Stylings and use colors to define a state. This is dropped since the Information is inaccessible. Please use the new Label, or StatusInformation API instead, they are designed to be inclusive.
  6. Christoph Lehmann abandoned the change 03/03/24, 20:08

    #103211 introduced a way for hightlighting tree items