Review main Merged

83184[DOCS] Improve example in changelog about tree node labels

Chris Müller CR +2 V +2 Normal +42 −14 updated 03/04/24, 12:17

Commit message

Use a full example of an event listener and enclose the RGB value in
quotes. The example also omits named arguments. Additionally, we have
currently no "tsconfig" language in the Sphinx-based rendering,
"typoscript" is used therefore. Also, captions are added for the code
blocks for easier adoption.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1114

  1. Chris Müller uploaded patch set 1 03/04/24, 08:48

  2. Chris Müller updated the commit message in patch set 2 03/04/24, 08:49

  3. core-ci voted on patch set 1 V +1 03/04/24, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53813

  4. core-ci voted on patch set 2 V +1 03/04/24, 08:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53814

  5. Benni Mack voted on patch set 2 CR +1 V +1 03/04/24, 09:07

  6. Christian Kuhn commented on patch set 2 03/04/24, 09:08

    Feature-103211-IntroduceTreeNodeLabels.rst:61

    when you want to have a full class example, you can as well declare that class readonly ;)

    Feature-103211-IntroduceTreeNodeLabels.rst:72

    note: i think we should *not* promote named parameters. we need to find a consensus and best practice doc within the core team about that soon, but for now, i think we should not document named parameters (this detalis nagged me on the .rst already).
  7. Chris Müller commented on patch set 2 CR -1 03/04/24, 10:32

    on it
  8. Chris Müller uploaded patch set 3 CR +1 V +1 03/04/24, 10:35

  9. Chris Müller commented on patch set 3 03/04/24, 10:35

    Feature-103211-IntroduceTreeNodeLabels.rst:61 Reply

    Done

    Feature-103211-IntroduceTreeNodeLabels.rst:72 Reply

    Done
  10. core-ci voted on patch set 3 V +1 03/04/24, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53822

  11. Stefan Bürk voted on patch set 3 CR +1 V +1 03/04/24, 11:36

  12. Christian Kuhn voted on patch set 3 CR +1 V +1 03/04/24, 11:38

  13. Stefan Bürk voted on patch set 3 CR +2 V +2 03/04/24, 12:17

  14. Stefan Bürk merged patch set 4 03/04/24, 12:17