Review main Merged

83192[TASK] Use more Fluid Standalone ViewHelpers

Simon Praetorius CR +2 V +2 Expert +0 −1275 updated 03/04/24, 20:09

Commit message

With Fluid 2.10.0, which is a required dependency, ViewHelpers from
TYPO3 without any TYPO3 dependency have been extracted to Fluid
Standalone. This patch removes the now duplicate ViewHelpers from
TYPO3.

This patch is non-breaking since:

* The affected ViewHelpers are final classes
* The global f: namespace falls back already to ViewHelpers from
Fluid Standalone

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Mathias Brodala +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 911

  1. Simon Praetorius uploaded patch set 1 03/04/24, 12:07

  2. core-ci voted on patch set 1 V +1 03/04/24, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53836

  3. Mathias Brodala commented on patch set 1 03/04/24, 13:18

    How about this instead: > Use more Fluid Standalone viewhelpers Technically there is no move here, the viewhelpers are already present in Fluid Standalone, only the TYPO3-specific overrides are dropped.
  4. Simon Praetorius updated the commit message in patch set 2 V +1 03/04/24, 13:32

  5. Mathias Brodala commented on patch set 2 CR +1 V +1 03/04/24, 13:34

    Verified by understanding of the namespace system and TYPO3 CI.
  6. Mathias Brodala commented on patch set 2 03/04/24, 13:34

    Reply

    Done
  7. core-ci voted on patch set 2 V +1 03/04/24, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53847

  8. Georg Ringer voted on patch set 2 CR +1 V +1 03/04/24, 20:03

  9. Benni Mack voted on patch set 2 CR +2 V +2 03/04/24, 20:06

  10. Benni Mack merged patch set 3 03/04/24, 20:06

  11. Benni Mack commented on patch set 3 03/04/24, 20:09

    <f:uri.external> and <f:link.external> can also be moved btw.