83192[TASK] Use more Fluid Standalone ViewHelpers
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Mathias Brodala +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Mathias Brodala +1
- core-ci +1 CI
Issues 1
Files 13
- typo3/sysext/fluid/Classes/ViewHelpers/Format/CaseViewHelper.phpdeleted+0 −159
- typo3/sysext/fluid/Classes/ViewHelpers/Format/JsonViewHelper.phpdeleted+0 −103
- typo3/sysext/fluid/Classes/ViewHelpers/Format/Nl2brViewHelper.phpdeleted+0 −75
- typo3/sysext/fluid/Classes/ViewHelpers/Format/NumberViewHelper.phpdeleted+0 −80
- typo3/sysext/fluid/Classes/ViewHelpers/Format/StripTagsViewHelper.phpdeleted+0 −121
- typo3/sysext/fluid/Classes/ViewHelpers/Format/TrimViewHelper.phpdeleted+0 −134
- typo3/sysext/fluid/Classes/ViewHelpers/Format/UrlencodeViewHelper.phpdeleted+0 −91
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/CaseViewHelperTest.phpdeleted+0 −103
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/Nl2brViewHelperTest.phpdeleted+0 −56
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/NumberViewHelperTest.phpdeleted+0 −64
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/StripTagsViewHelperTest.phpdeleted+0 −88
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/TrimViewHelperTest.phpdeleted+0 −121
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/UrlencodeViewHelperTest.phpdeleted+0 −80
Review log 911
-
Simon Praetorius uploaded patch set 1 03/04/24, 12:07
-
core-ci voted on patch set 1 V +1 03/04/24, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53836
-
Mathias Brodala commented on patch set 1 03/04/24, 13:18
How about this instead: > Use more Fluid Standalone viewhelpers Technically there is no move here, the viewhelpers are already present in Fluid Standalone, only the TYPO3-specific overrides are dropped. -
Simon Praetorius updated the commit message in patch set 2
V +103/04/24, 13:32 -
Mathias Brodala commented on patch set 2 CR +1 V +1 03/04/24, 13:34
Verified by understanding of the namespace system and TYPO3 CI. -
Mathias Brodala commented on patch set 2 03/04/24, 13:34
Reply
Done -
core-ci voted on patch set 2 V +1 03/04/24, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53847
-
Georg Ringer voted on patch set 2 CR +1 V +1 03/04/24, 20:03
-
Benni Mack voted on patch set 2 CR +2 V +2 03/04/24, 20:06
-
Benni Mack merged patch set 3 03/04/24, 20:06
-
Benni Mack commented on patch set 3 03/04/24, 20:09
<f:uri.external> and <f:link.external> can also be moved btw.