83204[TASK] Replace GeneralUtility::hmac usage in ext:install
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Julian Lichte +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Julian Lichte +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 12
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+3 −1
- typo3/sysext/core/Classes/ServiceProvider.php+7 −0
- typo3/sysext/install/Classes/Controller/BackendModuleController.php+5 −17
- typo3/sysext/install/Classes/Controller/InstallerController.php+3 −1
- typo3/sysext/install/Classes/Controller/LayoutController.php+3 −2
- typo3/sysext/install/Classes/Controller/ServerResponseCheckController.php+5 −6
- typo3/sysext/install/Classes/Middleware/Installer.php+9 −8
- typo3/sysext/install/Classes/Middleware/Maintenance.php+29 −30
- typo3/sysext/install/Classes/Service/Session/FileSessionHandler.php2+7 −3
- typo3/sysext/install/Classes/Service/SessionService.php+6 −7
- typo3/sysext/install/Classes/SystemEnvironment/ServerResponse/ServerResponseCheck.php+3 −2
- typo3/sysext/install/Classes/ServiceProvider.php+24 −2
Review log 2027
Show 12 earlier messages
-
Torben Hansen uploaded patch set 1 03/04/24, 19:23
-
core-ci voted on patch set 1 V +1 03/04/24, 19:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53896
-
Stefan Bürk voted on patch set 1 CR +1 V +1 03/04/24, 22:15
-
Benjamin Franzke commented on patch set 1 CR -1 03/05/24, 07:57
-
Torben Hansen uploaded patch set 2
CR +1V +103/05/24, 08:52 -
core-ci voted on patch set 2 V -1 03/05/24, 09:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53922
-
Benjamin Franzke uploaded patch set 3
V -103/05/24, 09:55 -
Torben Hansen commented on patch set 3 03/05/24, 10:01
FileSessionHandler.php:67ReplyDone. Also had to inject `SessionService` via DI now, since it was instantiated using `new` in some classes. -
core-ci voted on patch set 3 V -1 03/05/24, 10:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53927
-
Benjamin Franzke uploaded patch set 4
V -103/05/24, 10:57 -
core-ci voted on patch set 4 V -1 03/05/24, 11:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53932
-
Benjamin Franzke uploaded patch set 5
V -103/05/24, 11:24 -
core-ci voted on patch set 5 V +1 03/05/24, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53935
-
Benjamin Franzke voted on patch set 5 CR +1 V +1 03/05/24, 11:31
-
Christian Kuhn commented on patch set 5 CR -1 03/05/24, 16:02
on it. -
Christian Kuhn uploaded patch set 6
CR +1V +103/05/24, 17:20 -
Christian Kuhn commented on patch set 6 03/05/24, 17:24
looks good but waiting for another reviewer. -
Christian Kuhn voted on patch set 6 CR -1 03/05/24, 17:24
-
core-ci voted on patch set 6 V +1 03/05/24, 17:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53973
-
Julian Lichte commented on patch set 6 CR +1 V +1 03/05/24, 18:03
Reviewed the code and verified the logic, (also what happens, when I destroy my session at the beginning) it all looks good.Issue #102761 should be mentioned as related line. I allready related this ticket in the ticket #103251. -
Christian Kuhn voted on patch set 6 CR +1 V +1 03/05/24, 18:07
-
Christian Kuhn updated the commit message in patch set 7
CR +1V +103/05/24, 18:09 -
Christian Kuhn commented on patch set 7 CR +1 V +1 03/05/24, 18:09
Reply
Done -
Julian Lichte commented on patch set 7 CR +1 V +1 03/05/24, 18:10
Looks good! -
core-ci voted on patch set 7 V +1 03/05/24, 18:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53977
-
Benjamin Franzke voted on patch set 7 CR +2 V +2 03/05/24, 20:01
-
Benjamin Franzke merged patch set 8 03/05/24, 20:01
FileSessionHandler.php:67