Review main Merged

83204[TASK] Replace GeneralUtility::hmac usage in ext:install

Torben Hansen CR +2 V +2 Normal +104 −79 updated 03/05/24, 20:01

Commit message

With #102761, the new `HashService` has been introduced to ensure
that HMAC generation will always use an additional secret. As a
follow-up patch, `GeneralUtility::hmac` will be deprecated when all
usages in the core have been replaced with the new `HashService`.

With this change, usages of `GeneralUtility::hmac` in ext:install are
replaced by the new HashService.

Additionally, we now use DI for `SessionService` in various classes.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Julian Lichte +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Julian Lichte +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 12

Review log 2027

Show 12 earlier messages
  1. Torben Hansen uploaded patch set 1 03/04/24, 19:23

  2. core-ci voted on patch set 1 V +1 03/04/24, 19:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53896

  1. Stefan Bürk voted on patch set 1 CR +1 V +1 03/04/24, 22:15

  2. Benjamin Franzke commented on patch set 1 CR -1 03/05/24, 07:57

    FileSessionHandler.php:67

    Please inject HashService into EXT:install SessionServie (that is basically the factory for this handler) and pass hashService to the constructor of FileSessionHandler (this class).
  3. Torben Hansen uploaded patch set 2 CR +1 V +1 03/05/24, 08:52

  4. core-ci voted on patch set 2 V -1 03/05/24, 09:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53922

  5. Benjamin Franzke uploaded patch set 3 V -1 03/05/24, 09:55

  6. Torben Hansen commented on patch set 3 03/05/24, 10:01

    FileSessionHandler.php:67 Reply

    Done. Also had to inject `SessionService` via DI now, since it was instantiated using `new` in some classes.
  7. core-ci voted on patch set 3 V -1 03/05/24, 10:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53927

  8. Benjamin Franzke uploaded patch set 4 V -1 03/05/24, 10:57

  9. core-ci voted on patch set 4 V -1 03/05/24, 11:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53932

  10. Benjamin Franzke uploaded patch set 5 V -1 03/05/24, 11:24

  11. core-ci voted on patch set 5 V +1 03/05/24, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53935

  12. Benjamin Franzke voted on patch set 5 CR +1 V +1 03/05/24, 11:31

  13. Christian Kuhn commented on patch set 5 CR -1 03/05/24, 16:02

    on it.
  14. Christian Kuhn uploaded patch set 6 CR +1 V +1 03/05/24, 17:20

  15. Christian Kuhn commented on patch set 6 03/05/24, 17:24

    looks good but waiting for another reviewer.
  16. Christian Kuhn voted on patch set 6 CR -1 03/05/24, 17:24

  17. core-ci voted on patch set 6 V +1 03/05/24, 17:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53973

  18. Julian Lichte commented on patch set 6 CR +1 V +1 03/05/24, 18:03

    Reviewed the code and verified the logic, (also what happens, when I destroy my session at the beginning) it all looks good.
    Issue #102761 should be mentioned as related line. I allready related this ticket in the ticket #103251.
  19. Christian Kuhn voted on patch set 6 CR +1 V +1 03/05/24, 18:07

  20. Christian Kuhn updated the commit message in patch set 7 CR +1 V +1 03/05/24, 18:09

  21. Christian Kuhn commented on patch set 7 CR +1 V +1 03/05/24, 18:09

    Reply

    Done
  22. Julian Lichte commented on patch set 7 CR +1 V +1 03/05/24, 18:10

    Looks good!
  23. core-ci voted on patch set 7 V +1 03/05/24, 18:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53977

  24. Benjamin Franzke voted on patch set 7 CR +2 V +2 03/05/24, 20:01

  25. Benjamin Franzke merged patch set 8 03/05/24, 20:01