83223[TASK] Improve rendering of history
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 1013
-
Georg Ringer uploaded patch set 1 03/05/24, 22:41
-
Georg Ringer commented on patch set 1 03/05/24, 22:41
This change is ready for review. -
core-ci voted on patch set 1 V +1 03/05/24, 22:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53992
-
Garvin Hicking commented on patch set 1 03/13/24, 10:36
Unresolved
I like that this is clearer, but I see two issues: 1: If a new table cell is introduced, for accessibility (screen readers) we should have a proper <th> for it, not a colspan. Something like "Record title | Table" (we could re-use locallang_db_new_content_el.xlf:common_table_title for this label) 2: The table now gets very wide, instead of previously wrapping the record title in one cell, another one is now added which may hold long table names. It already got crowded before: https://www.dropbox.com/s/ghzamxq6l1ypflu/Screenshot%202024-03-13%20at%2011.34.02.png?dl=1 and now is even more horizontal scrolling: https://www.dropbox.com/s/2xq92xyioobkvkh/Screenshot%202024-03-13%20at%2011.34.38.png?dl=1 https://www.dropbox.com/s/oyixkox7s2ypuuc/Screenshot%202024-03-13%20at%2011.34.55.png?dl=1 -
Georg Ringer uploaded patch set 2
V +103/15/24, 13:13 -
core-ci voted on patch set 2 V +1 03/15/24, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54592
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 03/18/24, 15:46
-
Jasmina Ließmann uploaded patch set 3
CR +1V +103/18/24, 21:57 -
Jasmina Ließmann commented on patch set 2 V -1 03/18/24, 22:00
Unresolved
For editors, the table name is less relevant than the title of the record. I would therefore like to see this information continue to be placed below the title. The notation "(table:uid)" is derived from the representation in the log module. For the sake of consistency, I would also like to keep this spelling. For example: > Record "Foo" (pages:3) was updated -
core-ci voted on patch set 3 V +1 03/18/24, 22:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54669
-
Jasmina Ließmann voted on patch set 3 V -1 03/18/24, 22:06
-
Jasmina Ließmann commented on patch set 3 03/20/24, 10:50
I experimented a bit and took a slightly different approach. See: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83528 (I didn't want to hijack your patch and didn't know if two patches to the same ticket would cause problems, so I created a new ticket + patch). Screenshots of before/after are attached to the ticket. The “action” is shown there as a badge. But I'm unsure whether that's appropriate. My aim with the <strong> at this point was to ensure that the word/column didn't get lost, given all the information in the other columns. -
Georg Ringer abandoned the change 03/29/24, 09:53
abandoned in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/83528