Review main Merged

83259[DOCS] Switch linkvalidator documentation to PHP-based rendering

Lina Wolf CR +2 V +2 Normal +24 −108 updated 03/07/24, 05:42

Commit message

* Introduce a guides.xml, the presence of this file
  triggers the new rendering.
* Remove superfluous genindex, it is not supported anymore
* Remove old Settings.cfg, was only used for Sphinx

Attention: Backports need manual changes to the guides.xml.

Review

  • Code review CR +2 Done
    • Lina Wolf +2
    • Chris Müller +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Lina Wolf +2
    • Chris Müller +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 56

  1. Lina Wolf uploaded patch set 1 03/06/24, 14:45

  2. core-ci voted on patch set 1 V +1 03/06/24, 14:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54043

  3. Chris Müller commented on patch set 1 CR +1 V +1 03/06/24, 16:31

    For those who want to test: Switch to the extension directory execute: docker run --rm --pull always -v $(pwd):/project -it ghcr.io/typo3-documentation/render-guides:latest --config=Documentation More information: https://docs.typo3.org/m/typo3/docs-how-to-document/draft/en-us/RenderingDocs/Index.html
  4. Garvin Hicking voted on patch set 1 CR +1 V +1 03/06/24, 21:49

  5. Lina Wolf voted on patch set 1 CR +2 V +2 03/07/24, 05:42

  6. Lina Wolf merged patch set 2 03/07/24, 05:42