Review 12.4 Merged

83263[TASK] Add composer-mode to our acceptance test matrix

Benjamin Franzke CR +2 V +2 Hard +814 −118 updated 03/19/24, 05:30

Commit message

All applicable acceptance tests are now also executed
in composer mode. Tests that check classic-mode specific
functions are excluded and are therefore now tagged
as classic-mode test.

The composer mode instance is generated with our
CLI setup tools, allowing to mimic the realworld
case where a instance is creating via our setup tools
instead of from fixtures (which we still use for classic
mode tests, but try to reducde/avoid for composer mode tests).

The existing existing classic-mode test acceptance test
execution will keep running as-is.

The v12 backport additionally imports pieces from #102440
as t3editor extension is enabled in this composer-mode,
while v12 classic mode is tested (for historic reasons)
without t3editor extension enabled.

Commands executed:

  > composer require --dev "typo3/cms-styleguide":"^12.0.5"

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 38

Show 18 more files

Review log 2048

Show 823 earlier messages
  1. Benjamin Franzke uploaded patch set 1 03/06/24, 16:14

  2. core-ci voted on patch set 1 V -1 03/06/24, 16:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54053

  3. Benjamin Franzke uploaded patch set 2 V -1 03/11/24, 11:17

  4. core-ci voted on patch set 2 V -1 03/11/24, 11:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54355

  5. core-ci commented on patch set 2 03/11/24, 13:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54355

  6. Benjamin Franzke uploaded patch set 3 V -1 03/11/24, 16:31

  7. core-ci voted on patch set 3 V -1 03/11/24, 16:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54378

  8. Benjamin Franzke uploaded patch set 4 V -1 03/11/24, 16:57

  9. core-ci voted on patch set 4 V -1 03/11/24, 17:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54380

  10. core-ci commented on patch set 4 03/11/24, 17:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54380

  11. core-ci commented on patch set 4 03/11/24, 17:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54380

  12. core-ci commented on patch set 4 03/11/24, 17:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54380

  13. core-ci commented on patch set 4 03/11/24, 17:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54380

  14. Benjamin Franzke uploaded patch set 5 V -1 03/11/24, 18:32

  15. core-ci voted on patch set 5 V -1 03/11/24, 18:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54382

  16. Benjamin Franzke uploaded patch set 6 V -1 03/12/24, 11:05

  17. core-ci voted on patch set 6 V -1 03/12/24, 11:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54416

  18. Benjamin Franzke uploaded patch set 7 V -1 03/12/24, 12:54

  19. core-ci voted on patch set 7 V -1 03/12/24, 13:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54432

  20. Benjamin Franzke uploaded patch set 8 V -1 03/12/24, 15:40

  21. core-ci voted on patch set 8 V -1 03/12/24, 15:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54438

  22. core-ci commented on patch set 8 03/12/24, 15:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54438

  23. core-ci commented on patch set 8 03/12/24, 16:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54438

  1. Benjamin Franzke uploaded patch set 9 V -1 03/12/24, 17:40

  2. core-ci voted on patch set 9 V -1 03/12/24, 17:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54442

  3. core-ci commented on patch set 9 03/12/24, 19:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54442

  4. Benjamin Franzke uploaded patch set 10 V -1 03/13/24, 03:38

  5. core-ci voted on patch set 10 V -1 03/13/24, 03:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54450

  6. Benjamin Franzke uploaded patch set 11 V -1 03/13/24, 04:49

  7. core-ci voted on patch set 11 V -1 03/13/24, 04:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54451

  8. Benjamin Franzke uploaded patch set 12 V -1 03/13/24, 05:34

  9. core-ci voted on patch set 12 V -1 03/13/24, 05:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54452

  10. Benjamin Franzke uploaded patch set 13 V -1 03/13/24, 06:46

  11. core-ci voted on patch set 13 V +1 03/13/24, 06:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54453

  12. core-ci voted on patch set 13 V -1 03/13/24, 07:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54456

  13. core-ci voted on patch set 13 V +1 03/13/24, 07:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54456

  14. Benjamin Franzke uploaded patch set 14 V +1 03/13/24, 10:21

  15. core-ci voted on patch set 14 V +1 03/13/24, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54466

  16. Benjamin Franzke uploaded patch set 15 V +1 03/13/24, 13:36

  17. core-ci voted on patch set 15 V +1 03/13/24, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54479

  18. Benjamin Franzke uploaded patch set 16 V +1 03/16/24, 10:19

  19. core-ci voted on patch set 16 V +1 03/16/24, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54615

  20. core-ci voted on patch set 16 V -1 03/16/24, 10:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54617

  21. core-ci voted on patch set 16 V +1 03/16/24, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54617

  22. Benjamin Franzke marked it ready for review 03/16/24, 15:16

  23. Christian Kuhn voted on patch set 16 CR +1 V +1 03/17/24, 14:00

  24. Benjamin Franzke voted on patch set 16 CR +2 V +2 03/19/24, 05:30

  25. Benjamin Franzke merged patch set 17 03/19/24, 05:30