Review main Merged

83266[TASK] Replace GeneralUtility::hmac usage in ext:form

Torben Hansen CR +2 V +2 Normal +49 −29 updated 03/11/24, 10:38

Commit message

With #102761, the new `HashService` has been introduced to ensure
that HMAC generation will always use an additional secret. As a
follow-up patch, `GeneralUtility::hmac` will be deprecated when all
usages in the core have been replaced with the new `HashService`.

With this change, usages of `GeneralUtility::hmac` in ext:form
are replaced by the new HashService.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 9

Review log 45

  1. Torben Hansen uploaded patch set 1 03/06/24, 17:20

  2. core-ci voted on patch set 1 V +1 03/06/24, 17:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54061

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 03/11/24, 10:29

  4. Stefan Bürk voted on patch set 1 CR +2 V +2 03/11/24, 10:38

  5. Stefan Bürk merged patch set 2 03/11/24, 10:38