Review main Merged

83267[DOCS] Add documentation for font plugin to CKEditor5

Chris Müller CR +2 V +2 Normal +52 −0 updated 03/07/24, 08:42

Commit message

Review

  • Code review CR +2 Done
    • Lina Wolf +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Lina Wolf +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1519

  1. Chris Müller uploaded patch set 1 03/06/24, 17:27

  2. Chris Müller marked it work in progress 03/06/24, 17:27

  3. core-ci voted on patch set 1 V +1 03/06/24, 17:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54062

  4. Chris Müller rebased onto patch set 2 V +1 03/06/24, 19:31

  5. Chris Müller marked it ready for review 03/06/24, 19:32

  6. core-ci voted on patch set 2 V +1 03/06/24, 19:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54072

  7. Stefan Bürk voted on patch set 2 CR +1 V +1 03/06/24, 21:26

  8. Garvin Hicking voted on patch set 2 CR +1 V +1 03/06/24, 21:42

  9. Lina Wolf commented on patch set 2 03/07/24, 06:14

    Thanks for this good example, just some small remarks

    Examples.rst:164

    I would suggest to put the yaml in a literalinclude file so we can easier preserve the whitespaces which play a large role in yaml...

    Examples.rst:203

    I think the link text should contain where we link, something like official documentation of the ckeditor project
  10. Chris Müller uploaded patch set 3 CR +1 V +1 03/07/24, 08:05

  11. Chris Müller commented on patch set 3 03/07/24, 08:06

    Examples.rst:164 Reply

    Will do this in a follow-up - then with all snippets.

    Examples.rst:203 Reply

    Done
  12. Lina Wolf voted on patch set 3 CR +1 V +1 03/07/24, 08:07

  13. Lina Wolf commented on patch set 3 CR +2 V +2 03/07/24, 08:07

    Only minor text changes after the last result
  14. Lina Wolf voted on patch set 3 CR +1 V +1 03/07/24, 08:08

  15. core-ci voted on patch set 3 V -1 03/07/24, 08:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54111

  16. core-ci voted on patch set 3 V +1 03/07/24, 08:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54111

  17. Garvin Hicking voted on patch set 3 CR +1 V +1 03/07/24, 08:40

  18. Lina Wolf voted on patch set 3 CR +2 V +2 03/07/24, 08:42

  19. Lina Wolf merged patch set 4 03/07/24, 08:42