83267[DOCS] Add documentation for font plugin to CKEditor5
Commit message
Review
-
Code review CR +2 Done
- Lina Wolf +2
- Garvin Hicking +1
-
Verified V +2 Done
- Lina Wolf +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1519
-
Chris Müller uploaded patch set 1 03/06/24, 17:27
-
Chris Müller marked it work in progress 03/06/24, 17:27
-
core-ci voted on patch set 1 V +1 03/06/24, 17:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54062
-
Chris Müller rebased onto patch set 2
V +103/06/24, 19:31 -
Chris Müller marked it ready for review 03/06/24, 19:32
-
core-ci voted on patch set 2 V +1 03/06/24, 19:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54072
-
Stefan Bürk voted on patch set 2 CR +1 V +1 03/06/24, 21:26
-
Garvin Hicking voted on patch set 2 CR +1 V +1 03/06/24, 21:42
-
Lina Wolf commented on patch set 2 03/07/24, 06:14
Thanks for this good example, just some small remarksExamples.rst:164I would suggest to put the yaml in a literalinclude file so we can easier preserve the whitespaces which play a large role in yaml...Examples.rst:203I think the link text should contain where we link, something like official documentation of the ckeditor project -
Chris Müller uploaded patch set 3
CR +1V +103/07/24, 08:05 -
Chris Müller commented on patch set 3 03/07/24, 08:06
Examples.rst:164ReplyWill do this in a follow-up - then with all snippets.Examples.rst:203ReplyDone -
Lina Wolf voted on patch set 3 CR +1 V +1 03/07/24, 08:07
-
Lina Wolf commented on patch set 3 CR +2 V +2 03/07/24, 08:07
Only minor text changes after the last result -
Lina Wolf voted on patch set 3 CR +1 V +1 03/07/24, 08:08
-
core-ci voted on patch set 3 V -1 03/07/24, 08:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54111
-
core-ci voted on patch set 3 V +1 03/07/24, 08:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54111
-
Garvin Hicking voted on patch set 3 CR +1 V +1 03/07/24, 08:40
-
Lina Wolf voted on patch set 3 CR +2 V +2 03/07/24, 08:42
-
Lina Wolf merged patch set 4 03/07/24, 08:42