Review main Merged

83297[DOCS] Update linkvalidator codesnippets

Lina Wolf CR +2 V +2 Hard +141 −143 updated 03/07/24, 13:28

Commit message

* Make the code-snippets auto-generatable
* Remove API for internal class
* Fix references

Attention: Backport need manual changes.

Review

  • Code review CR +2 Done
    • Lina Wolf +2
    • Chris Müller +1
  • Verified V +2 Done
    • Lina Wolf +2
    • Chris Müller +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1416

  1. Lina Wolf uploaded patch set 1 03/07/24, 09:15

  2. Lina Wolf uploaded patch set 2 03/07/24, 09:16

  3. core-ci voted on patch set 1 V +1 03/07/24, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54119

  4. core-ci voted on patch set 2 V +1 03/07/24, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54120

  5. Chris Müller commented on patch set 2 CR -1 03/07/24, 10:30

    LinkAnalyzerResult.rst:1

    Why is the LinkAnalyzerResult dropped?
  6. Lina Wolf commented on patch set 2 03/07/24, 10:31

    LinkAnalyzerResult.rst:1 Reply

    because it is internal: Remove API for internal class
  7. Chris Müller commented on patch set 2 03/07/24, 11:01

    LinkAnalyzerResult.rst:1 Reply

    Okay, please create then an events page where the event is mentioned, for example, like here: https://docs.typo3.org/c/typo3/cms-redirects/12.4/en-us/Events/Index.html So the event is referenced in this sysext docs. And: I know we have to discuss if we move the events to the dedicated sysext manuals. I am still not convinced that this may be really better than the central place. So, mentioning and referencing would be good for now.
  8. Lina Wolf commented on patch set 2 03/07/24, 11:13

    LinkAnalyzerResult.rst:1 Reply

    The event is linked from the API section already
  9. Lina Wolf commented on patch set 2 03/07/24, 11:14

  10. Chris Müller commented on patch set 2 03/07/24, 11:53

    LinkAnalyzerResult.rst:1 Reply

    Hmm, in the other sysext manuals there is a dedicated "Events" chapter (where applicable). We should do it the same, and not sometimes here and sometimes there.
  11. Lina Wolf commented on patch set 2 03/07/24, 11:54

    LinkAnalyzerResult.rst:1 Reply

    Can we do that in a follow up?
  12. Chris Müller commented on patch set 2 CR 0 03/07/24, 13:18

    LinkAnalyzerResult.rst:1 Reply

    Fine with that.
  13. Chris Müller commented on patch set 2 03/07/24, 13:19

    LinkAnalyzerResult.rst:1 Reply

    Acknowledged
  14. Chris Müller voted on patch set 2 CR +1 V +1 03/07/24, 13:19

  15. Lina Wolf voted on patch set 2 CR +2 V +2 03/07/24, 13:27

  16. Lina Wolf merged patch set 3 03/07/24, 13:28