83297[DOCS] Update linkvalidator codesnippets
Commit message
Review
-
Code review CR +2 Done
- Lina Wolf +2
- Chris Müller +1
-
Verified V +2 Done
- Lina Wolf +2
- Chris Müller +1
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/linkvalidator/Documentation/CodeSnippets/Api/AbstractLinktype.rst.txt+24 −17
- typo3/sysext/linkvalidator/Documentation/CodeSnippets/Api/LinkAnalyzerResult.rst.txtdeleted+0 −53
- typo3/sysext/linkvalidator/Documentation/CodeSnippets/Api/LinktypeInterface.rst.txt+25 −23
- typo3/sysext/linkvalidator/Documentation/CodeSnippets/Config/All.phpnew+33 −0
- typo3/sysext/linkvalidator/Documentation/CodeSnippets/Examples/ActivateCustomLinktypeTsConfig.rst.txt+8 −5
- typo3/sysext/linkvalidator/Documentation/CodeSnippets/Examples/ExampleLinkType.rst.txt+39 −25
- typo3/sysext/linkvalidator/Documentation/Development/Api/Index.rst+0 −1
- typo3/sysext/linkvalidator/Documentation/Development/Api/LinkAnalyzerResult.rst9deleted+0 −15
- typo3/sysext/linkvalidator/Documentation/Development/LinkTypeImplementation.rst+4 −4
- typo3/sysext/linkvalidator/Documentation/codesnippets.phpnew+8 −0
Review log 1416
-
Lina Wolf uploaded patch set 1 03/07/24, 09:15
-
Lina Wolf uploaded patch set 2 03/07/24, 09:16
-
core-ci voted on patch set 1 V +1 03/07/24, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54119
-
core-ci voted on patch set 2 V +1 03/07/24, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54120
-
Chris Müller commented on patch set 2 CR -1 03/07/24, 10:30
-
Lina Wolf commented on patch set 2 03/07/24, 10:31
LinkAnalyzerResult.rst:1Replybecause it is internal: Remove API for internal class -
Chris Müller commented on patch set 2 03/07/24, 11:01
LinkAnalyzerResult.rst:1ReplyOkay, please create then an events page where the event is mentioned, for example, like here: https://docs.typo3.org/c/typo3/cms-redirects/12.4/en-us/Events/Index.html So the event is referenced in this sysext docs. And: I know we have to discuss if we move the events to the dedicated sysext manuals. I am still not convinced that this may be really better than the central place. So, mentioning and referencing would be good for now. -
Lina Wolf commented on patch set 2 03/07/24, 11:13
LinkAnalyzerResult.rst:1ReplyThe event is linked from the API section already -
Lina Wolf commented on patch set 2 03/07/24, 11:14
LinkAnalyzerResult.rst:1Reply -
Chris Müller commented on patch set 2 03/07/24, 11:53
LinkAnalyzerResult.rst:1ReplyHmm, in the other sysext manuals there is a dedicated "Events" chapter (where applicable). We should do it the same, and not sometimes here and sometimes there. -
Lina Wolf commented on patch set 2 03/07/24, 11:54
LinkAnalyzerResult.rst:1ReplyCan we do that in a follow up? -
Chris Müller commented on patch set 2 CR 0 03/07/24, 13:18
LinkAnalyzerResult.rst:1ReplyFine with that. -
Chris Müller commented on patch set 2 03/07/24, 13:19
LinkAnalyzerResult.rst:1ReplyAcknowledged -
Chris Müller voted on patch set 2 CR +1 V +1 03/07/24, 13:19
-
Lina Wolf voted on patch set 2 CR +2 V +2 03/07/24, 13:27
-
Lina Wolf merged patch set 3 03/07/24, 13:28
LinkAnalyzerResult.rst:1