83298[BUGFIX] Fix cropScale calculation in ImageProcessingInstructions
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Simon Praetorius +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Simon Praetorius +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 4
- typo3/sysext/core/Classes/Imaging/ImageProcessingInstructions.php+2 −2
- typo3/sysext/core/Tests/Unit/Imaging/ImageProcessingInstructionsTest.php+4 −4
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/ImageViewHelperTest.php+0 −4
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/ImageViewHelperTest.php+0 −4
Review log 912
-
Benjamin Franzke uploaded patch set 1 03/07/24, 09:19
-
core-ci voted on patch set 1 V +1 03/07/24, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54121
-
Benni Mack updated the commit message in patch set 2
V +103/07/24, 18:45 -
core-ci voted on patch set 2 V +1 03/07/24, 18:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54180
-
Benjamin Franzke commented on patch set 2 CR -1 03/07/24, 21:05
Thanks Benni for updating the commit message. (We still need a functional test here. Therefore -1 for now) -
Benjamin Franzke uploaded patch set 3
CR -1V +103/08/24, 18:38 -
Benjamin Franzke commented on patch set 3 03/08/24, 18:39
Ready -
core-ci voted on patch set 3 V +1 03/08/24, 18:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54301
-
Benni Mack voted on patch set 3 CR +1 V +1 03/08/24, 19:21
-
Simon Praetorius voted on patch set 3 CR +1 V +1 03/08/24, 20:38
-
Benjamin Franzke voted on patch set 3 CR +2 V +2 03/08/24, 21:03
-
Benjamin Franzke merged patch set 4 03/08/24, 21:03