Review main Merged

83298[BUGFIX] Fix cropScale calculation in ImageProcessingInstructions

Benjamin Franzke CR +2 V +2 Easy +6 −14 updated 03/08/24, 21:03

Commit message

While refactoring the cropping information calculation in September
2023 by Benni Mack, the cropWidth / cropHeight and the offsets
were set to the wrong constructor arguments.

The patch reverses the order of the constructor of the CropArea
object.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Simon Praetorius +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Simon Praetorius +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 912

  1. Benjamin Franzke uploaded patch set 1 03/07/24, 09:19

  2. core-ci voted on patch set 1 V +1 03/07/24, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54121

  3. Benni Mack updated the commit message in patch set 2 V +1 03/07/24, 18:45

  4. core-ci voted on patch set 2 V +1 03/07/24, 18:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54180

  5. Benjamin Franzke commented on patch set 2 CR -1 03/07/24, 21:05

    Thanks Benni for updating the commit message. (We still need a functional test here. Therefore -1 for now)
  6. Benjamin Franzke uploaded patch set 3 CR -1 V +1 03/08/24, 18:38

  7. Benjamin Franzke commented on patch set 3 03/08/24, 18:39

    Ready
  8. core-ci voted on patch set 3 V +1 03/08/24, 18:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54301

  9. Benni Mack voted on patch set 3 CR +1 V +1 03/08/24, 19:21

  10. Simon Praetorius voted on patch set 3 CR +1 V +1 03/08/24, 20:38

  11. Benjamin Franzke voted on patch set 3 CR +2 V +2 03/08/24, 21:03

  12. Benjamin Franzke merged patch set 4 03/08/24, 21:03