Review main Merged

83303[TASK] Remove internal declaration for hashService property in actionController

Torben Hansen CR +2 V +2 Easy +1 −5 updated 03/07/24, 15:33

Commit message

With #92996 the property `hashService` in extbase `actionController`
has been marked as internal. This change was most likely made,
because the extbase `hashService` class was declared as internal.

The extbase `HashService` has been deprecated with #102763 and
extbase `actionController` now uses the new `HashService` introduced
with #102761, which is public API. Therefore, the internal declaration
for the property `hashService` in `actionController` can be removed
again, so extension authors can use the `hashService` for e.g. HMAC
validation.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 4

Files 1

Review log 56

  1. Torben Hansen uploaded patch set 1 03/07/24, 14:38

  2. Torben Hansen wrote 03/07/24, 14:39

    Topic set to EXT: extbase
  3. core-ci voted on patch set 1 V +1 03/07/24, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54142

  4. Oliver Klee voted on patch set 1 CR +1 V +1 03/07/24, 15:17

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 03/07/24, 15:32

  6. Christian Kuhn merged patch set 2 03/07/24, 15:33