Review main Merged

83306[TASK] Streamline userid/username handling and system-maintainer checks

Oliver Hader CR +2 V +2 Normal +71 −58 updated 03/12/24, 12:03

Commit message

The new methods AbstractUserAuthentication::getUserName() and
AbstractUserAuthentication::getUserId() can be used to resolve
the corresponding values (instead of using the $user->user array).

In addition, the pure system-maintainer checks have been moved into
to central BackendUserAuthentication::isSystemMaintainer(). The term
"pure" refers to ignoring the development context and not applying
any fallbacks in case the setting is empty.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 19

Review log 78

  1. Oliver Hader uploaded patch set 1 03/07/24, 15:47

  2. core-ci voted on patch set 1 V +1 03/07/24, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54147

  3. Anja Leichsenring voted on patch set 1 CR +1 V +1 03/08/24, 08:50

  4. Benni Mack voted on patch set 1 CR +1 V +1 03/11/24, 22:51

  5. Christian Kuhn voted on patch set 1 CR +1 V +1 03/12/24, 11:27

  6. Oliver Klee voted on patch set 1 CR +1 03/12/24, 11:31

  7. Oliver Hader voted on patch set 1 CR +2 V +2 03/12/24, 11:49

  8. Oliver Hader merged patch set 2 03/12/24, 12:03